You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 17:36:13 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2941: Remove ObjectStoreRegistry::clone
tustvold opened a new pull request, #2941:
URL: https://github.com/apache/arrow-datafusion/pull/2941
https://github.com/apache/arrow-datafusion/pull/2906/files#r922872640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2941: Use `Arc` and remove ObjectStoreRegistry::clone
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2941:
URL: https://github.com/apache/arrow-datafusion/pull/2941#issuecomment-1188020324
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2941](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc62474) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/305e2650522e40a3704ef0e2b4e069b94f1c1e15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (305e265) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #2941 +/- ##
==========================================
+ Coverage 85.32% 85.39% +0.07%
==========================================
Files 273 273
Lines 49498 49441 -57
==========================================
- Hits 42235 42221 -14
+ Misses 7263 7220 -43
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/src/datasource/object\_store.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhc291cmNlL29iamVjdF9zdG9yZS5ycw==) | `84.44% <100.00%> (ø)` | |
| [datafusion/core/src/execution/runtime\_env.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9leGVjdXRpb24vcnVudGltZV9lbnYucnM=) | `75.00% <100.00%> (ø)` | |
| [datafusion/proto/src/to\_proto.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9wcm90by9zcmMvdG9fcHJvdG8ucnM=) | `53.40% <0.00%> (-3.07%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `76.78% <0.00%> (-0.36%)` | :arrow_down: |
| [...atafusion/physical-expr/src/aggregate/array\_agg.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvYXJyYXlfYWdnLnJz) | `95.87% <0.00%> (-0.05%)` | :arrow_down: |
| [...sion/physical-expr/src/aggregate/count\_distinct.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvY291bnRfZGlzdGluY3QucnM=) | `95.03% <0.00%> (+0.01%)` | :arrow_up: |
| [datafusion/physical-expr/src/aggregate/tdigest.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvdGRpZ2VzdC5ycw==) | `91.30% <0.00%> (+0.05%)` | :arrow_up: |
| [datafusion/common/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci5ycw==) | `84.81% <0.00%> (+0.06%)` | :arrow_up: |
| [...fusion/physical-expr/src/aggregate/sum\_distinct.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvc3VtX2Rpc3RpbmN0LnJz) | `92.72% <0.00%> (+0.06%)` | :arrow_up: |
| [datafusion/proto/src/lib.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9wcm90by9zcmMvbGliLnJz) | `93.47% <0.00%> (+0.15%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/arrow-datafusion/pull/2941/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [305e265...bc62474](https://codecov.io/gh/apache/arrow-datafusion/pull/2941?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2941: Use `Arc` and remove ObjectStoreRegistry::clone
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2941:
URL: https://github.com/apache/arrow-datafusion/pull/2941#issuecomment-1188051101
Benchmark runs are scheduled for baseline = 9414a74efabc78fb2b08981665df56030c37dfb8 and contender = a2be1dc397fde42a1b24e810c14bb1ed109a304a. a2be1dc397fde42a1b24e810c14bb1ed109a304a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/62b5a28b729b4a8ca8d1c453b781de2e...602eefcf46e14f78a069104479a173a9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8a8dd07f262b40128cbe83d416d75fe9...656116f1d95f41dda516fa6c090fc712/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/517a9d2963ea4b5b8e97374115d843ac...0b21a3bf8cb04aa5b2afb956b9d23b74/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1c341ea033154b2b9ef5f955bfe52149...62178048bee2488ab7029b34ebae7511/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #2941: Use `Arc` and remove ObjectStoreRegistry::clone
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2941:
URL: https://github.com/apache/arrow-datafusion/pull/2941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org