[jira] [Work logged] (WW-5124) Tag attribute values cached

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WW-5124?focusedWorklogId=607594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607594 ]

ASF GitHub Bot logged work on WW-5124:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/21 02:58
            Start Date: 07/Jun/21 02:58
    Worklog Time Spent: 10m 
      Work Description: JCgH4164838Gh792C124B5 opened a new pull request #489:
URL: https://github.com/apache/struts/pull/489


   WW-5124 - Proposed fix for Struts JSP tag behaviour on application servers that use tag pooling.
   - Prior to this change, on application serves such as Glassfish, tag pools that re-use tag instances demonstrated incorrect behaviour, due to previous / old tag state still being present.
   - Added new clearTagStateForTagPoolingServers() to StrutsBodyTagSupport.  It is called in doEndTag(), and descendants that override doEndTag() should call the ancestor method or directly call clearTagStateForTagPoolingServers().
   - Unit test support methods were added to StrutsInternalTestCase and AbstractTagTest.
   - Basic sanity checks for existing unit tests were added where feasible.  They reflection-compare a tag's state after doEndTag() is called with that of a new instance, to help catch if future changes miss calls in the
   clearTagStateForTagPoolingServers() hierarchy.
   - Removed some unused imports, added some missing override annotations to classes that were modified as part of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 607594)
    Remaining Estimate: 0h
            Time Spent: 10m

> Tag attribute values cached
> ---------------------------
>
>                 Key: WW-5124
>                 URL: https://issues.apache.org/jira/browse/WW-5124
>             Project: Struts 2
>          Issue Type: Bug
>         Environment: Here you have a repo that reproduce this:
> https://github.com/dfliess/struts2-tagpooling-bug
>            Reporter: Diego Alejandro Fliess
>            Priority: Major
>             Fix For: 2.5.27, 2.6
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> On some application servers, like glassfish, when handling jsp tag pooling, attribute values are cached or not reinitiallized.
> For example:
> {code:java}
> <s:textfield size="50">
>     <jsp:attribute name="placeholder">THIS TEXTFIELD SHOULD HAVE VALUE</jsp:attribute>
>     <jsp:attribute name="value">VALUE</jsp:attribute>
> </s:textfield>
> <s:textfieldsize="50">
>     <jsp:attribute name="placeholder">THIS TEXT FIELD SHOULDN'T HAVE VALUE</jsp:attribute>
> </s:textfield>{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)