[GitHub] [helix] pkuwm edited a comment on issue #700: Call session aware createEphemeral to create live instance.

[GitBox <gi...@apache.org>]

pkuwm edited a comment on issue #700: Call session aware createEphemeral to create live instance.
URL: https://github.com/apache/helix/pull/700#issuecomment-577890940
 
 
   Thanks for the prompt review, @jiajunwang @narendly !
   I've run the tests again and all passed.
   
   This PR is ready to be merged, approved by @jiajunwang @narendly 
   
   ```
   Live instance creation is still using the old API createEphemeral(path, data) without the session ID, resulting in zk session race condition being not completely fixed.
   
   So this commit changes the api to use createEphemeral(path, data, sessionId) for zk session validation and live instance creation. A new unit test is also added to cover session expiry in participant manager when creating live instance.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org