You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/14 08:22:56 UTC

[GitHub] [druid] clintropolis opened a new pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct

clintropolis opened a new pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct
URL: https://github.com/apache/druid/pull/9363
 
 
   Also improves javadocs of `Expr.getIdentifierIfIdentifier` and `Expr.getBindingIfIdentifier`. This isn't an actual bug because the expressions that `Expressions.toQueryGranularity` can recognize and transform are limited to cases where the time floor expressions argument `Identifier.identifier` will always match `IdentifierExpr.binding`, but changed anyway to be more consistent with intention of the method.
   
   Related #9362
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] fjy merged pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct

Posted by GitBox <gi...@apache.org>.
fjy merged pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct
URL: https://github.com/apache/druid/pull/9363
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org