You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:27:36 UTC

[GitHub] [incubator-doris] adonis0147 commented on a diff in pull request #8786: [improvement] Refactor type info for further optimizations.

adonis0147 commented on code in PR #8786:
URL: https://github.com/apache/incubator-doris/pull/8786#discussion_r845819989


##########
be/src/olap/field.h:
##########
@@ -278,7 +278,7 @@ class Field {
 
     FieldType type() const { return _type_info->type(); }
     FieldAggregationMethod aggregation() const { return _agg_info->agg_method(); }
-    const TypeInfo* type_info() const { return _type_info; }
+    const TypeInfo* type_info() const { return _type_info.get(); }

Review Comment:
   I agree that it is a potential risk which we should avoid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org