You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andy-hf-kwok (via GitHub)" <gi...@apache.org> on 2025/10/16 04:05:09 UTC
[PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
andy-hf-kwok opened a new pull request, #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588
## Which issue does this PR close?
This PR aims to address the `-Wnumeric-widen` warning in the codebase.
As the overall scope of strict-warning compliance is quite large, this change focuses on resolving this specific warning type as a first step. Future PRs will continue addressing other warning incrementally.
Partially closes #. https://github.com/apache/datafusion-comet/issues/2255
## Rationale for this change
To clean up the code as per static check with the hope to resolve all warning and promote the restrict warning profile for the default CI build to uphold Scala code quality.
## What changes are included in this PR?
To perform explicit type conversion instead of relying on runtime implicit cast.
## How are these changes tested?
* Code can now compile with `-Wnumeric-widen` option on.
* CI continue to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2438377159
##########
pom.xml:
##########
@@ -738,14 +738,14 @@ under the License.
<artifactId>scala-maven-plugin</artifactId>
<configuration>
<args>
- <arg>-deprecation</arg>
- <arg>-unchecked</arg>
- <arg>-feature</arg>
- <arg>-Xlint:_</arg>
- <arg>-Ywarn-dead-code</arg>
+<!-- <arg>-deprecation</arg>-->
Review Comment:
Nope, reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2436038868
##########
pom.xml:
##########
@@ -738,14 +738,14 @@ under the License.
<artifactId>scala-maven-plugin</artifactId>
<configuration>
<args>
- <arg>-deprecation</arg>
- <arg>-unchecked</arg>
- <arg>-feature</arg>
- <arg>-Xlint:_</arg>
- <arg>-Ywarn-dead-code</arg>
+<!-- <arg>-deprecation</arg>-->
Review Comment:
Are these intended changes down here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2436917411
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -416,15 +416,15 @@ abstract class ParquetReadSuite extends CometTestBase {
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
its probably can be directly casted to int?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2588: Chore: Code hygiene - warn-numeric-widen
URL: https://github.com/apache/datafusion-comet/pull/2588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#issuecomment-3507192805
@comphead @mbutrovich I have removed some explicit conversions and added a suppression instead, as it seems more appropriate.
Would you mind to trigger the CI for this PR?
Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2507372825
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -416,15 +416,15 @@ abstract class ParquetReadSuite extends CometTestBase {
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
Actually I think if the test suite is mean to examine the behaviour when `Byte` or `Short` being passed, then we should keep it as it is.
I have reverted some `.toInt` on test suites for this purpose and add a suppression annotation instead.
@comphead @EmilyMatt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "EmilyMatt (via GitHub)" <gi...@apache.org>.
EmilyMatt commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2461928215
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -416,15 +416,15 @@ abstract class ParquetReadSuite extends CometTestBase {
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
I believe overflow behaviour will be different and lead to unexpected and incorrect results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2507372825
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -416,15 +416,15 @@ abstract class ParquetReadSuite extends CometTestBase {
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
Actually I think if the test suite is mean to examine the behaviour when `Byte` or `Short` being passed, then we should keep it as it is.
I have reverted some `.toInt` under some of the test suites for this purpose and add a suppression annotation instead.
@comphead @EmilyMatt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2438377159
##########
pom.xml:
##########
@@ -738,14 +738,14 @@ under the License.
<artifactId>scala-maven-plugin</artifactId>
<configuration>
<args>
- <arg>-deprecation</arg>
- <arg>-unchecked</arg>
- <arg>-feature</arg>
- <arg>-Xlint:_</arg>
- <arg>-Ywarn-dead-code</arg>
+<!-- <arg>-deprecation</arg>-->
Review Comment:
Nope, reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#issuecomment-3409142125
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 11.01%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a1f1b3c`](https://app.codecov.io/gh/apache/datafusion-comet/commit/a1f1b3c83fcb3e33605a8961a206683ad50d0af4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 614 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...t/execution/shuffle/CometShuffleExchangeExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2Fexecution%2Fshuffle%2FCometShuffleExchangeExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvZXhlY3V0aW9uL3NodWZmbGUvQ29tZXRTaHVmZmxlRXhjaGFuZ2VFeGVjLnNjYWxh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...a/org/apache/comet/parquet/SourceFilterSerde.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fparquet%2FSourceFilterSerde.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9wYXJxdWV0L1NvdXJjZUZpbHRlclNlcmRlLnNjYWxh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/spark/sql/comet/CometColumnarToRowExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometColumnarToRowExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRDb2x1bW5hclRvUm93RXhlYy5zY2FsYQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ala/org/apache/spark/sql/comet/CometScanExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometScanExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRTY2FuRXhlYy5zY2FsYQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/spark/sql/comet/CometSparkToColumnarExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometSparkToColumnarExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRTcGFya1RvQ29sdW1uYXJFeGVjLnNjYWxh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/spark/sql/comet/CometBatchScanExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometBatchScanExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRCYXRjaFNjYW5FeGVjLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/comet/CometBroadcastExchangeExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometBroadcastExchangeExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRCcm9hZGNhc3RFeGNoYW5nZUV4ZWMuc2NhbGE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/spark/sql/comet/CometCollectLimitExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometCollectLimitExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRDb2xsZWN0TGltaXRFeGVjLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ark/sql/comet/CometTakeOrderedAndProjectExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2FCometTakeOrderedAndProjectExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvQ29tZXRUYWtlT3JkZXJlZEFuZFByb2plY3RFeGVjLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ecution/shuffle/CometBlockStoreShuffleReader.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fcomet%2Fexecution%2Fshuffle%2FCometBlockStoreShuffleReader.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvY29tZXQvZXhlY3V0aW9uL3NodWZmbGUvQ29tZXRCbG9ja1N0b3JlU2h1ZmZsZVJlYWRlci5zY2FsYQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2588 +/- ##
=============================================
- Coverage 56.12% 11.01% -45.12%
+ Complexity 976 232 -744
=============================================
Files 119 146 +27
Lines 11743 13737 +1994
Branches 2251 2334 +83
=============================================
- Hits 6591 1513 -5078
- Misses 4012 12047 +8035
+ Partials 1140 177 -963
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2588?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2436920403
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -558,15 +558,15 @@ abstract class CometTestBase
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
same, can be probably converted directly
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -1104,8 +1104,8 @@ abstract class CometTestBase
val record = new SimpleGroup(schema)
opt match {
case Some(i) =>
- record.add(0, i.toByte)
- record.add(1, i.toShort)
+ record.add(0, i.toByte.toInt)
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2507371903
##########
pom.xml:
##########
@@ -738,14 +738,14 @@ under the License.
<artifactId>scala-maven-plugin</artifactId>
<configuration>
<args>
- <arg>-deprecation</arg>
- <arg>-unchecked</arg>
- <arg>-feature</arg>
- <arg>-Xlint:_</arg>
- <arg>-Ywarn-dead-code</arg>
+<!-- <arg>-deprecation</arg>-->
Review Comment:
Reveted.
##########
pom.xml:
##########
@@ -738,14 +738,14 @@ under the License.
<artifactId>scala-maven-plugin</artifactId>
<configuration>
<args>
- <arg>-deprecation</arg>
- <arg>-unchecked</arg>
- <arg>-feature</arg>
- <arg>-Xlint:_</arg>
- <arg>-Ywarn-dead-code</arg>
+<!-- <arg>-deprecation</arg>-->
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "andy-hf-kwok (via GitHub)" <gi...@apache.org>.
andy-hf-kwok commented on code in PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#discussion_r2507373484
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -558,15 +558,15 @@ abstract class CometTestBase
opt match {
case Some(i) =>
record.add(0, i % 2 == 0)
- record.add(1, i.toByte)
- record.add(2, i.toShort)
+ record.add(1, i.toByte.toInt)
Review Comment:
see above reply, I believe in this case it's more appropriate to keep it as it is, so that we can assert the implicit conversation behaviour on test suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Chore: Code hygiene - warn-numeric-widen [datafusion-comet]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2588:
URL: https://github.com/apache/datafusion-comet/pull/2588#issuecomment-3888292805
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org