You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 07:26:12 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31453: [SPARK-34340][CORE] Support ZSTD JNI BufferPool

dongjoon-hyun commented on a change in pull request #31453:
URL: https://github.com/apache/spark/pull/31453#discussion_r569183105



##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1680,6 +1680,13 @@ package object config {
       .bytesConf(ByteUnit.BYTE)
       .createWithDefaultString("32k")
 
+  private[spark] val IO_COMPRESSION_ZSTD_ENABLE_BUFFERPOOL =
+    ConfigBuilder("spark.io.compression.zstd.enableBufferPool")

Review comment:
       Thank you for review. I cannot make `bufferPool` as a new namespace because we have only one configuration here `enableBufferPool`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org