You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/07/07 14:54:07 UTC
Review Request 60708: Log Search UI: implement dynamic loading of
options for filters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60708/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-21429
https://issues.apache.org/jira/browse/AMBARI-21429
Repository: ambari
Description
-------
Options for logs list filters should be loaded dynamically based on real application data.
Diffs
-----
ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 65139db
ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts b1b691c
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts 8828390
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts 8291572
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts 652b864
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts ea3d780
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts 5cfe4cc
ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts d5f8881
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts a8dc017
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts ce451d3
ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts 4ab85e5
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts faed254
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts 49dfa77
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts a50c68d
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts b3b955a
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/clusters.service.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/components.service.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts a06852c
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts 0abd910
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts 4e47609
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts PRE-CREATION
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts ab77138
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts 36cfd5f
ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts 732e8d3
Diff: https://reviews.apache.org/r/60708/diff/1/
Testing
-------
Executed 46 of 46 SUCCESS (1.22 secs / 1.185 secs)
Thanks,
Andrii Babiichuk
Re: Review Request 60708: Log Search UI: implement dynamic loading of
options for filters
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60708/#review179873
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Июль 7, 2017, 2:54 п.п., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60708/
> -----------------------------------------------------------
>
> (Updated Июль 7, 2017, 2:54 п.п.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-21429
> https://issues.apache.org/jira/browse/AMBARI-21429
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Options for logs list filters should be loaded dynamically based on real application data.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 65139db
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts b1b691c
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.spec.ts 8828390
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.spec.ts 8291572
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts 652b864
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.spec.ts ea3d780
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts 5cfe4cc
> ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts d5f8881
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.spec.ts a8dc017
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts ce451d3
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts 4ab85e5
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts faed254
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts 49dfa77
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts a50c68d
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts b3b955a
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/clusters.service.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/components.service.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts a06852c
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts 0abd910
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts 4e47609
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts PRE-CREATION
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts ab77138
> ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts 36cfd5f
> ambari-logsearch/ambari-logsearch-web-new/src/assets/mock-data.ts 732e8d3
>
>
> Diff: https://reviews.apache.org/r/60708/diff/1/
>
>
> Testing
> -------
>
> Executed 46 of 46 SUCCESS (1.22 secs / 1.185 secs)
>
>
> Thanks,
>
> Andrii Babiichuk
>
>