You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 15:16:53 UTC
[GitHub] [incubator-nuttx-apps] YuuichiNakamura opened a new pull request #429: Fix note_syscall_leave_s to avoid unaligned access
YuuichiNakamura opened a new pull request #429:
URL: https://github.com/apache/incubator-nuttx-apps/pull/429
## Summary
App code support for https://github.com/apache/incubator-nuttx/pull/2005
"note" and "trace" commands are fixed.
## Impact
See https://github.com/apache/incubator-nuttx/pull/2005
## Testing
See https://github.com/apache/incubator-nuttx/pull/2005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #429: Fix note_syscall_leave_s to avoid unaligned access
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #429:
URL: https://github.com/apache/incubator-nuttx-apps/pull/429#discussion_r506969806
##########
File path: system/sched_note/note_main.c
##########
@@ -457,6 +457,7 @@ static void dump_notes(size_t nread)
{
FAR struct note_spinlock_s *note_spinlock =
(FAR struct note_spinlock_s *)note;
+ FAR void *spinlock;
Review comment:
BTW, @YuuichiNakamura could you update note_main.c to support syscall/irq you add recently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #429: Fix note_syscall_leave_s to avoid unaligned access
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #429:
URL: https://github.com/apache/incubator-nuttx-apps/pull/429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #429: Fix note_syscall_leave_s to avoid unaligned access
Posted by GitBox <gi...@apache.org>.
YuuichiNakamura commented on a change in pull request #429:
URL: https://github.com/apache/incubator-nuttx-apps/pull/429#discussion_r507155706
##########
File path: system/sched_note/note_main.c
##########
@@ -457,6 +457,7 @@ static void dump_notes(size_t nread)
{
FAR struct note_spinlock_s *note_spinlock =
(FAR struct note_spinlock_s *)note;
+ FAR void *spinlock;
Review comment:
@xiaoxiang781216 These are already supported by note_main.c line 592-671.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org