You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 03:17:49 UTC
[GitHub] [flink] dforciea opened a new pull request #13787: Flink 19771
dforciea opened a new pull request #13787:
URL: https://github.com/apache/flink/pull/13787
## What is the purpose of the change
Fixes an issue where null arrays in postgres cause a NullPointerException when retrieving data
## Brief change log
- Update PostgresRowConverter to override createInternalConverter rather than createNullableInternalConverter
- Update tests to include cases for null postgres arrays, for both paths of the PostgresRowConverter (both bytea[] and standard arrays)
## Verifying this change
This change added tests and can be verified as follows:
- Amended getArrayTable in PostgresCatalogTestBase to include fields for null bytea[] and standard arrays
- Update PostgresCatalogITCase to expect nulls for these columns
- Validated that this test failed before the change, and succeeds after the change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ee445aac08ecae0dd55add35411b67a0ec0b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254)
* 9f01c7c985006870473bfde649b2f38988c423bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f01c7c985006870473bfde649b2f38988c423bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ee445aac08ecae0dd55add35411b67a0ec0b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254)
* 9f01c7c985006870473bfde649b2f38988c423bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19522][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ee445aac08ecae0dd55add35411b67a0ec0b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
}, {
"hash" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12341",
"triggerID" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f01c7c985006870473bfde649b2f38988c423bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120)
* bb9752d65c868d8d0ab5632fc2a7ee91b941b54e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
}, {
"hash" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12341",
"triggerID" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb9752d65c868d8d0ab5632fc2a7ee91b941b54e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13787: [FLINK-19522][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ee445aac08ecae0dd55add35411b67a0ec0b01 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #13787:
URL: https://github.com/apache/flink/pull/13787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716280232
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bb9752d65c868d8d0ab5632fc2a7ee91b941b54e (Fri May 28 07:12:16 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19522][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ee445aac08ecae0dd55add35411b67a0ec0b01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13787: [FLINK-19522][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716280232
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 93ee445aac08ecae0dd55add35411b67a0ec0b01 (Mon Oct 26 03:20:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dforciea commented on pull request #13787: [FLINK-19522][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
dforciea commented on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716280150
The second commit gets rid of the PostgresRowConverterTest that I had originally added. Let me know if you think this is useful, and I can bring it back. Otherwise, I'll just rebase and eliminate that commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13787: [FLINK-19771][jdbc] Fix NPE when accessing array using postgres
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13787:
URL: https://github.com/apache/flink/pull/13787#issuecomment-716285196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8254",
"triggerID" : "93ee445aac08ecae0dd55add35411b67a0ec0b01",
"triggerType" : "PUSH"
}, {
"hash" : "9f01c7c985006870473bfde649b2f38988c423bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120",
"triggerID" : "9f01c7c985006870473bfde649b2f38988c423bd",
"triggerType" : "PUSH"
}, {
"hash" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bb9752d65c868d8d0ab5632fc2a7ee91b941b54e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f01c7c985006870473bfde649b2f38988c423bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9120)
* bb9752d65c868d8d0ab5632fc2a7ee91b941b54e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org