[GitHub] [incubator-yunikorn-k8shim] anuraagnalluri commented on pull request #369: [YUNIKORN-1040] add e2e test that re-starts the scheduler pod

[GitBox <gi...@apache.org>]

anuraagnalluri commented on pull request #369:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/369#issuecomment-1055024454


   @yangwwei Right, something is definitely off about the port-forwarding. If I use `exec.Output` or `exec.CombinedOutput`, I get a failure likely due to it being a blocking operation (which is why I went the route of using `exec.Start`). But this is swallowing the following error:
   ```
    Unexpected error:
         <*exec.ExitError | 0x1400054e000>: {
             ProcessState: {
                 pid: 69190,
                 status: 256,
                 rusage: {
                     Utime: {
                         Sec: 0,
                         Usec: 62424,
                         Pad_cgo_0: [0, 0, 0, 0],
                     },
                     Stime: {
                         Sec: 0,
                         Usec: 20745,
                         Pad_cgo_0: [0, 0, 0, 0],
                     },
                     Maxrss: 45203456,
                     Ixrss: 0,
                     Idrss: 0,
                     Isrss: 0,
                     Minflt: 3441,
                     Majflt: 34,
                     Nswap: 0,
                     Inblock: 0,
                     Oublock: 0,
                     Msgsnd: 17,
                     Msgrcv: 10,
                     Nsignals: 76,
                     Nvcsw: 67,
                     Nivcsw: 1116,
                 },
             },
             Stderr: nil,
         }
         exit status 1
   ```
   
   I thought about using `client-go/tools` for a go-native implementation as explained here: https://gianarb.it/blog/programmatically-kube-port-forward-in-go . But if we put the termination and port-forwarding logic in goroutines and use `sync/WaitGroup`, then this would still be a blocking operation, right?
   
   Happy to look in to any other suggestions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org