You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gp...@apache.org on 2011/09/02 14:04:08 UTC

svn commit: r1164497 - /myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java

Author: gpetracek
Date: Fri Sep  2 12:04:08 2011
New Revision: 1164497

URL: http://svn.apache.org/viewvc?rev=1164497&view=rev
Log:
EXTCDI-221 ignore incoming window-id if it doesn't exist internally and unknown window-ids aren't allowed

Modified:
    myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java

Modified: myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java?rev=1164497&r1=1164496&r2=1164497&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/util/JsfUtils.java Fri Sep  2 12:04:08 2011
@@ -145,11 +145,18 @@ public abstract class JsfUtils
     {
         StringBuilder finalUrl = new StringBuilder(url);
         boolean existingParameters = url.contains("?");
+        boolean urlContainsWindowId = url.contains("windowId=");
 
         for(RequestParameter requestParam : getRequestParameters(externalContext, true))
         {
             String key = requestParam.getKey();
 
+            //TODO eval if we should also filter the other params
+            if("windowId".equals(key) && urlContainsWindowId)
+            {
+                continue;
+            }
+
             for(String parameterValue : requestParam.getValues())
             {
                 if(!url.contains(key + "=" + parameterValue))