You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/13 08:23:04 UTC
[GitHub] [airflow] potiuk opened a new pull request, #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
potiuk opened a new pull request, #33362:
URL: https://github.com/apache/airflow/pull/33362
The new aiobotocore release 2.6.0 caused `pip` to backtract when finding `good` set of dependencies. This limitation should stop the backtracking until other dependncies causing the conflicts will be updated.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33362:
URL: https://github.com/apache/airflow/pull/33362#discussion_r1292736093
##########
Dockerfile.ci:
##########
@@ -1375,8 +1375,8 @@ RUN echo "Airflow version: ${AIRFLOW_VERSION}"
# Those are additional constraints that are needed for some extras but we do not want to
# force them on the main Airflow package. Currently we need no extra limits as PIP 23.1+ has much better
# dependency resolution and we do not need to limit the versions of the dependencies
-# !!! MAKE SURE YOU SYNCHRONIZE THE LIST BETWEEN: Dockerfile, Dockerfile.ci
Review Comment:
I will remove it in the subsequent PR from `Dockerfile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33362:
URL: https://github.com/apache/airflow/pull/33362#issuecomment-1676320141
The PR with tooling that I used to find the culprit https://github.com/apache/airflow/pull/33364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33362:
URL: https://github.com/apache/airflow/pull/33362#discussion_r1292735918
##########
Dockerfile.ci:
##########
@@ -1375,8 +1375,8 @@ RUN echo "Airflow version: ${AIRFLOW_VERSION}"
# Those are additional constraints that are needed for some extras but we do not want to
# force them on the main Airflow package. Currently we need no extra limits as PIP 23.1+ has much better
# dependency resolution and we do not need to limit the versions of the dependencies
-# !!! MAKE SURE YOU SYNCHRONIZE THE LIST BETWEEN: Dockerfile, Dockerfile.ci
Review Comment:
Or not.... I SHOULD HAVE REMOVED IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33362:
URL: https://github.com/apache/airflow/pull/33362#discussion_r1292735817
##########
Dockerfile.ci:
##########
@@ -1375,8 +1375,8 @@ RUN echo "Airflow version: ${AIRFLOW_VERSION}"
# Those are additional constraints that are needed for some extras but we do not want to
# force them on the main Airflow package. Currently we need no extra limits as PIP 23.1+ has much better
# dependency resolution and we do not need to limit the versions of the dependencies
-# !!! MAKE SURE YOU SYNCHRONIZE THE LIST BETWEEN: Dockerfile, Dockerfile.ci
Review Comment:
Yes. I removed it long time ago -it's not been used there, only now I realized the comment is still here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #33362:
URL: https://github.com/apache/airflow/pull/33362#discussion_r1292728530
##########
Dockerfile.ci:
##########
@@ -1375,8 +1375,8 @@ RUN echo "Airflow version: ${AIRFLOW_VERSION}"
# Those are additional constraints that are needed for some extras but we do not want to
# force them on the main Airflow package. Currently we need no extra limits as PIP 23.1+ has much better
# dependency resolution and we do not need to limit the versions of the dependencies
-# !!! MAKE SURE YOU SYNCHRONIZE THE LIST BETWEEN: Dockerfile, Dockerfile.ci
Review Comment:
Does removing this comment mean that we don't need to synchronize with Dockerfile anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33362:
URL: https://github.com/apache/airflow/pull/33362#issuecomment-1676278920
More complete explanation and tooling (with examples on how to diagnose and fix similar issues) is coming - this one is there to unblock main and allow to make v2-7-test RC2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33362:
URL: https://github.com/apache/airflow/pull/33362#issuecomment-1676302397
cc: @ephraimbuddy -> cherry-pick that one before you push v2-7-test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33362: Limit aiobotocore for eager upgrade to prevent pip backtracking
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33362:
URL: https://github.com/apache/airflow/pull/33362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org