You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "mikelui (via GitHub)" <gi...@apache.org> on 2023/04/14 15:12:42 UTC
[GitHub] [arrow] mikelui opened a new issue, #35134: Place vendored double-conversion library in a private namespace
mikelui opened a new issue, #35134:
URL: https://github.com/apache/arrow/issues/35134
### Describe the enhancement requested
Double conversion is vendored in Arrow:
* https://github.com/apache/arrow/blob/main/cpp/src/arrow/vendored/double-conversion/double-conversion.h#L33
* https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/double_conversion.h#L26
This can cause symbol collisions when the Arrow library is linked into other libraries which use a different version of double-conversion.
The vendored version should be placed into its own namespace to avoid these symbol collisions.
This is a sub-issue of #34932
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #35134: [C++] Place vendored double-conversion library in a private namespace
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #35134: [C++] Place vendored double-conversion library in a private namespace
URL: https://github.com/apache/arrow/issues/35134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org