[GitHub] ArvinDevel opened a new pull request #851: Issue 578 : make MajorCompaction controlled by time of the day/day of the week

[GitBox <gi...@apache.org>]

ArvinDevel opened a new pull request #851: Issue 578 : make MajorCompaction controlled by time of the day/day of the week
URL: https://github.com/apache/bookkeeper/pull/851
 
 
   Descriptions of the changes in this PR:
   
   Add time of day based GC policy to MajorCompaction, when the time is in specified zone(here is when system is in low load status), it will adjust the gc threshold to specified value.
   In my opinion, after adding this policy to MajorCompaction, there is no need to add similar policy to MinorCompaction, because the MajorCompaction has done the deeper gc.
   Next, I will add a test case and explore the system load based policy.
   
   Master Issue: #<master-issue-number>
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue # or BOOKKEEPER-#>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   >     `e.g. BOOKKEEPER-1234: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services