Re: [PR] [#1938] improvement: Use ShuffleSegment to replace FileBasedShuffleSegment and BufferSegment [incubator-uniffle]

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on PR #1939:
URL: https://github.com/apache/incubator-uniffle/pull/1939#issuecomment-2295568254

   Sorry for the late reply.
   
   Thanks for proposing this. Actually the `ShuffleSegment` has been introduce to be as the an abstract class. And I think the initial design is to clarify the client/server side shuffleSegment. But I agree with the same part 6 variables should be defined in the existing ShuffleSegment. And there is no need to make the invoking side to use the ShuffleSegment to replace all the Filebased or Buffer segnment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org