You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by gk...@apache.org on 2026/08/15 09:03:50 UTC

(iggy) branch remove_outdated_todos created (now 15770cfd8)

This is an automated email from the ASF dual-hosted git repository.

numinnex pushed a change to branch remove_outdated_todos
in repository https://gitbox.apache.org/repos/asf/iggy.git


      at 15770cfd8 chore: remove resolved TODO comments

This branch includes the following new commits:

     new 15770cfd8 chore: remove resolved TODO comments

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(iggy) 01/01: chore: remove resolved TODO comments

Posted by gk...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

numinnex pushed a commit to branch remove_outdated_todos
in repository https://gitbox.apache.org/repos/asf/iggy.git

commit 15770cfd85b80852e8f4667e4f05d4d07e4412e4
Author: Grzegorz Koszyk <g....@gmail.com>
AuthorDate: Sat Aug 15 11:03:17 2026 +0200

    chore: remove resolved TODO comments
---
 core/journal/src/prepare_journal.rs     | 2 +-
 core/metadata/src/impls/metadata.rs     | 3 ---
 core/partitions/src/types.rs            | 1 -
 core/server/src/partition_reconciler.rs | 2 +-
 4 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/core/journal/src/prepare_journal.rs b/core/journal/src/prepare_journal.rs
index 9e665db83..f56a746ff 100644
--- a/core/journal/src/prepare_journal.rs
+++ b/core/journal/src/prepare_journal.rs
@@ -48,7 +48,7 @@ const MAX_ENTRY_SIZE: u64 = 64 * 1024 * 1024;
 ///
 /// Never re-sealed on receipt: the producer seals once and every replica stores that
 /// verbatim, so re-sealing locally would diverge the header bytes and break the
-/// parent chain in the TODO below.
+/// parent chain.
 const CHECKSUM_BODY_UNSEALED: u128 = 0;
 
 /// Number of slots in the journal ring buffer.
diff --git a/core/metadata/src/impls/metadata.rs b/core/metadata/src/impls/metadata.rs
index 94b372262..2bb877f9c 100644
--- a/core/metadata/src/impls/metadata.rs
+++ b/core/metadata/src/impls/metadata.rs
@@ -3434,9 +3434,6 @@ where
         }
     }
 
-    // TODO: Implement jump_to_newer_op
-    // fn jump_to_newer_op(&self, header: &PrepareHeader) {}
-
     /// Apply ops `[commit_min+1 .. commit_max]` to state machine and
     /// `client_table`. Backup does NOT ship wire replies (primary's job).
     ///
diff --git a/core/partitions/src/types.rs b/core/partitions/src/types.rs
index 5bc67b8e7..dcf4eb0b9 100644
--- a/core/partitions/src/types.rs
+++ b/core/partitions/src/types.rs
@@ -87,7 +87,6 @@ pub struct SendMessagesResult {
 }
 
 /// Consumer identification for offset operations.
-// TODO(hubcio): unify with server's `PollingConsumer` in `streaming/polling_consumer.rs`.
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum PollingConsumer {
     /// Regular consumer with (`consumer_id`, `partition_id`)
diff --git a/core/server/src/partition_reconciler.rs b/core/server/src/partition_reconciler.rs
index 278c2afb3..fa2d3f735 100644
--- a/core/server/src/partition_reconciler.rs
+++ b/core/server/src/partition_reconciler.rs
@@ -140,7 +140,7 @@
 //! so a parked op N is re-queued *behind* an op N+1 that was already sitting in
 //! the inbox. The partition plane then sees N+1 first, rejects it against its
 //! backup gap check, and N+1 is gone -- with no normal-status repair driver to
-//! refetch it (see the TODO below). Ordering has to be restored at the plane, by
+//! refetch it (see the TODO above). Ordering has to be restored at the plane, by
 //! buffering out-of-order prepares rather than dropping them, or by re-dispatching
 //! through a priority path that preserves op order.
 //!