[GitHub] [hadoop] steveloughran commented on a diff in pull request #5402: HADOOP-18635 : Expose distcp counters to user via new DistCpConstants "CONF_LABEL_DI…

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5402:
URL: https://github.com/apache/hadoop/pull/5402#discussion_r1109612693


##########
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSystem.java:
##########
@@ -452,7 +454,12 @@ public void testDistcpLargeFile() throws Exception {
     };
 
     LOG.info("_____ running distcp: " + args[0] + " " + args[1]);
-    ToolRunner.run(conf, new DistCp(), args);
+    DistCp distcpTool = new DistCp();
+    ToolRunner.run(conf, distcpTool, args);
+    final long bytesCopied = NumberUtils.toLong(distcpTool.getConf().
+            get(CONF_LABEL_DISTCP_TOTAL_BYTES_COPIED), 0);
+    assertEquals("Bytes copied by distcp tool should match source file length",

Review Comment:
   assert args are the wrong way round for the generated error messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org