You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Chris Lombardi (JIRA)" <ji...@apache.org> on 2008/02/28 16:49:51 UTC
[jira] Created: (OFBIZ-1687) POS: full credit card number is
printed on receipt
POS: full credit card number is printed on receipt
--------------------------------------------------
Key: OFBIZ-1687
URL: https://issues.apache.org/jira/browse/OFBIZ-1687
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/pos
Affects Versions: SVN trunk
Reporter: Chris Lombardi
Priority: Minor
Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573532#action_12573532 ]
Chris Lombardi commented on OFBIZ-1687:
---------------------------------------
I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.
If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1687) POS: full credit card
number is printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573532#action_12573532 ]
clearchris edited comment on OFBIZ-1687 at 2/28/08 4:56 PM:
----------------------------------------------------------------
I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.
If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.
EDIT: saw this on the mailing list, attaching to issue.
From: Vince M. Clark (vclark@globalera.com)
Sent: Thu 2/28/08 2:13 PM
To: dev@ofbiz.apache.org
Scott did this for us a few months ago. Scott, feel free to commit to trunk.
was (Author: clearchris):
I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.
If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Vince,
Jacques
From: "Vince M. Clark" <vc...@globalera.com>
> Scott did this for us a few months ago. Scott, feel free to commit to trunk.
>
> ----- Original Message -----
> From: "Jacques Le Roux (JIRA)" <ji...@apache.org>
> To: dev@ofbiz.apache.org
> Sent: Thursday, February 28, 2008 12:49:51 PM (GMT-0700) America/Denver
> Subject: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt
>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]
>
> Jacques Le Roux commented on OFBIZ-1687:
> ----------------------------------------
>
> Hi Chris,
>
> Have you a patch for this (before I look at it, seems simple) ?
>
>> POS: full credit card number is printed on receipt
>> --------------------------------------------------
>>
>> Key: OFBIZ-1687
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: specialpurpose/pos
>> Affects Versions: SVN trunk
>> Reporter: Chris Lombardi
>> Assignee: Jacques Le Roux
>> Priority: Minor
>>
>> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced
>> with asterisk or 'x' characters.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Vince M. Clark" <vc...@globalera.com>.
Scott did this for us a few months ago. Scott, feel free to commit to trunk.
----- Original Message -----
From: "Jacques Le Roux (JIRA)" <ji...@apache.org>
To: dev@ofbiz.apache.org
Sent: Thursday, February 28, 2008 12:49:51 PM (GMT-0700) America/Denver
Subject: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]
Jacques Le Roux commented on OFBIZ-1687:
----------------------------------------
Hi Chris,
Have you a patch for this (before I look at it, seems simple) ?
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]
Jacques Le Roux commented on OFBIZ-1687:
----------------------------------------
Hi Chris,
Have you a patch for this (before I look at it, seems simple) ?
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1687:
----------------------------------
Attachment: (was: ofbiz-1687-1.patch)
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1687:
----------------------------------
Attachment: ofbiz-1687-1.patch
Patch to add in formatPrintableCreditCard() and tests to base.
I'll add another patch to utilize this in POS, but not today.
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1687:
----------------------------------
Attachment: ofbiz-1687-1.patch
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1687:
----------------------------------
Attachment: ofbiz-1687-2.patch
This was easier than I thought it would be. Patch #2 removes the credit card printouts in the log and masks the card number printouts on the receipts.
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch, ofbiz-1687-2.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1687) POS: full credit card number is printed
on receipt
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1687.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Chris,
Your patches are in trunk rev. 637310
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-1687-1.patch, ofbiz-1687-2.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1687) POS: full credit card number is
printed on receipt
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1687:
--------------------------------------
Assignee: Jacques Le Roux
> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.