[arrow-rs] branch master updated: Address benchmarks that aren't compiling (#1001)

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new 99b7d01  Address benchmarks that aren't compiling (#1001)
99b7d01 is described below

commit 99b7d01103495607932343146c973b6fba0eb8d5
Author: Carol (Nichols || Goulding) <19...@users.noreply.github.com>
AuthorDate: Fri Dec 17 14:23:33 2021 -0500

    Address benchmarks that aren't compiling (#1001)
    
    * Add a CI job that checks benchmarks (but doesn't run them)
    
    * The feature test_common must be turned on to build parquet benchmarks
    
    * Align cache keys
    
    Co-authored-by: Andrew Lamb <an...@nerdnetworks.org>
    
    Co-authored-by: Andrew Lamb <an...@nerdnetworks.org>
---
 .github/workflows/rust.yml | 40 ++++++++++++++++++++++++++++++++++++++++
 parquet/Cargo.toml         |  1 +
 2 files changed, 41 insertions(+)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index dd95878..d73bb65 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -239,6 +239,46 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           cargo clippy --features test_common --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
 
+  check_benches:
+    name: Check Benchmarks (but don't run them)
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        arch: [amd64]
+        rust: [stable]
+    container:
+      image: ${{ matrix.arch }}/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+      - name: Cache Cargo
+        uses: actions/cache@v2
+        with:
+          path: /github/home/.cargo
+          # this key equals the ones on `linux-build-lib` for re-use
+          key: cargo-cache3-
+      - name: Cache Rust dependencies
+        uses: actions/cache@v2
+        with:
+          path: /github/home/target
+          # this key equals the ones on `linux-build-lib` for re-use
+          key: ${{ runner.os }}-${{ matrix.arch }}-target-cache3-${{ matrix.rust }}
+      - name: Setup Rust toolchain
+        run: |
+          rustup toolchain install ${{ matrix.rust }}
+          rustup default ${{ matrix.rust }}
+          rustup component add rustfmt clippy
+      - name: Check benchmarks
+        run: |
+          export CARGO_HOME="/github/home/.cargo"
+          export CARGO_TARGET_DIR="/github/home/target"
+          cargo check --benches --workspace
+
   lint:
     name: Lint
     runs-on: ubuntu-latest
diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index f777b10..d111abf 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -79,4 +79,5 @@ harness = false
 
 [[bench]]
 name = "arrow_array_reader"
+required-features = ["test_common"]
 harness = false