You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/07/22 01:18:35 UTC
Review Request 61060: Cached a reference to a ProcessBase in every
UPID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61060/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7798
https://issues.apache.org/jira/browse/MESOS-7798
Repository: mesos
Description
-------
Cached a reference to a ProcessBase in every UPID.
Diffs
-----
3rdparty/libprocess/include/process/pid.hpp 6ed936db2e45f3aab2c3765d57772844e702f914
3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c
3rdparty/libprocess/src/pid.cpp 634ac44337980fec03ceadaa81a7557d6a714af8
3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
3rdparty/libprocess/src/process_reference.hpp a6d6d20e3f40634c5e16fd193443e5f1e02faff5
Diff: https://reviews.apache.org/r/61060/diff/1/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 61060: Cached a reference to a ProcessBase in
every UPID.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61060/#review181424
-----------------------------------------------------------
This is also updating process.cpp from a refs counter to a shared_ptr, do you want to comment a bit on that in the description?
3rdparty/libprocess/include/process/pid.hpp
Lines 100-102 (patched)
<https://reviews.apache.org/r/61060/#comment256997>
Why is this public? Do we want users to call it?
3rdparty/libprocess/include/process/pid.hpp
Lines 131 (patched)
<https://reviews.apache.org/r/61060/#comment256998>
Why is this public? Do we want users to access / modify it?
Also, when is it None?
3rdparty/libprocess/include/process/process.hpp
Lines 464 (patched)
<https://reviews.apache.org/r/61060/#comment256999>
s/reference/references/? Is it still "active references"?
3rdparty/libprocess/src/process.cpp
Lines 2856-2868 (original), 2856-2871 (patched)
<https://reviews.apache.org/r/61060/#comment257001>
Hm.. when would it be None but found below? I'm a little puzzled on the nature of the reference, this make it look lazy, but it doesn't quite seem lazy looking at where we resolve.
3rdparty/libprocess/src/process.cpp
Lines 3128 (patched)
<https://reviews.apache.org/r/61060/#comment257000>
commit separately?
- Benjamin Mahler
On July 22, 2017, 1:18 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61060/
> -----------------------------------------------------------
>
> (Updated July 22, 2017, 1:18 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7798
> https://issues.apache.org/jira/browse/MESOS-7798
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cached a reference to a ProcessBase in every UPID.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/pid.hpp 6ed936db2e45f3aab2c3765d57772844e702f914
> 3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c
> 3rdparty/libprocess/src/pid.cpp 634ac44337980fec03ceadaa81a7557d6a714af8
> 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
> 3rdparty/libprocess/src/process_reference.hpp a6d6d20e3f40634c5e16fd193443e5f1e02faff5
>
>
> Diff: https://reviews.apache.org/r/61060/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 61060: Cached a reference to a ProcessBase in
every UPID.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61060/#review181761
-----------------------------------------------------------
Ship it!
Some TODOs with thoughts on the longer term plan here that we discussed would be great! (i.e. don't let users mutate the fields, hide resolve(), etc)
- Benjamin Mahler
On July 22, 2017, 1:18 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61060/
> -----------------------------------------------------------
>
> (Updated July 22, 2017, 1:18 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7798
> https://issues.apache.org/jira/browse/MESOS-7798
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cached a reference to a ProcessBase in every UPID.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/pid.hpp 6ed936db2e45f3aab2c3765d57772844e702f914
> 3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c
> 3rdparty/libprocess/src/pid.cpp 634ac44337980fec03ceadaa81a7557d6a714af8
> 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c
> 3rdparty/libprocess/src/process_reference.hpp a6d6d20e3f40634c5e16fd193443e5f1e02faff5
>
>
> Diff: https://reviews.apache.org/r/61060/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>