You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2016/01/12 07:10:06 UTC
Review Request 42180: FALCON-1733: Support for building falcon with
JDK 1.8 also.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1733
https://issues.apache.org/jira/browse/FALCON-1733
Repository: falcon-git
Description
-------
Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
Diffs
-----
checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
pom.xml 39ee9ac
prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
Diff: https://reviews.apache.org/r/42180/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 14, 2016, 2:55 p.m., Ajay Yadava wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 56
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line56>
> >
> > This should be relatively easy to fix, right? Can you give examples and number of violations?
It's easy to fix but actually we need this as in many places, we actually just dont use the return value. There are more than around 20 violations due to this.
> On Jan. 14, 2016, 2:55 p.m., Ajay Yadava wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 59
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line59>
> >
> > I will request to either fix them or limit the exposure to certain classes/packages. These are valid objections and should be handled appropriately instead of ignoring them.
Agreed. We can limit these to the certain classes/packages unless we want these for the entire project.
> On Jan. 14, 2016, 2:55 p.m., Ajay Yadava wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 60
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line60>
> >
> > This should be relatively easy to fix with no unexpected side effects, right?
Agreed. This is relatively easy to fix. We need to make the collections package to private.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review114479
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review114479
-----------------------------------------------------------
checkstyle/src/main/resources/falcon/findbugs-exclude.xml (line 56)
<https://reviews.apache.org/r/42180/#comment175331>
This should be relatively easy to fix, right? Can you give examples and number of violations?
checkstyle/src/main/resources/falcon/findbugs-exclude.xml (line 59)
<https://reviews.apache.org/r/42180/#comment175332>
I will request to either fix them or limit the exposure to certain classes/packages. These are valid objections and should be handled appropriately instead of ignoring them.
checkstyle/src/main/resources/falcon/findbugs-exclude.xml (line 60)
<https://reviews.apache.org/r/42180/#comment175330>
This should be relatively easy to fix with no unexpected side effects, right?
- Ajay Yadava
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 14, 2016, 9:43 a.m., Peeyush Bishnoi wrote:
> > common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java, line 147
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193867#file1193867line147>
> >
> > minor nit: Just add space around operator similar added to others e.g (jarFiles != null)
Will do it.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review114447
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review114447
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java (line 147)
<https://reviews.apache.org/r/42180/#comment175297>
minor nit: Just add space around operator similar added to others e.g (jarFiles != null)
- Peeyush Bishnoi
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113967
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 12, 2016, 8:22 a.m., pavan kumar kolamuri wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 52
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line52>
> >
> > Instead of adding here can't we fix these ?
As of now, we are not fixing these, as we dont know any aide-effects of the changes. May be we can open a separate jira to fix these changes.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Jan. 12, 2016, 8:22 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 322
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193877#file1193877line322>
> >
> > In the latest patch by pallavi this was again set null can you check once
<p>This is fine coz., he is setting wfParams only when PARAMS is the operation.</p>
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Jan. 12, 2016, 8:22 a.m., pavan kumar kolamuri wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 52
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line52>
> >
> > Instead of adding here can't we fix these ?
>
> Narayan Periwal wrote:
> As of now, we are not fixing these, as we dont know any aide-effects of the changes. May be we can open a separate jira to fix these changes.
Ok Narayan please raise jira for the same
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 12, 2016, 8:22 a.m., pavan kumar kolamuri wrote:
> > checkstyle/src/main/resources/falcon/findbugs-exclude.xml, line 52
> > <https://reviews.apache.org/r/42180/diff/1/?file=1193863#file1193863line52>
> >
> > Instead of adding here can't we fix these ?
>
> Narayan Periwal wrote:
> As of now, we are not fixing these, as we dont know any aide-effects of the changes. May be we can open a separate jira to fix these changes.
>
> pavan kumar kolamuri wrote:
> Ok Narayan please raise jira for the same
Pavan, Raised the jira. https://issues.apache.org/jira/browse/FALCON-1745
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review113945
-----------------------------------------------------------
checkstyle/src/main/resources/falcon/findbugs-exclude.xml (line 52)
<https://reviews.apache.org/r/42180/#comment174734>
Instead of adding here can't we fix these ?
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 322)
<https://reviews.apache.org/r/42180/#comment174726>
In the latest patch by pallavi this was again set null can you check once
- pavan kumar kolamuri
On Jan. 12, 2016, 6:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/#review115046
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Jan. 18, 2016, 11:32 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42180/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 11:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1733
> https://issues.apache.org/jira/browse/FALCON-1733
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
> client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
> client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java cebf968
> client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 7caacb5
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
> common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
> common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
> docs/src/site/twiki/InstallationSteps.twiki e8c76f7
> metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
> oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java 830641e
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
> oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
> pom.xml 39ee9ac
> prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
> replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
> test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
> webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 056c0a1
>
> Diff: https://reviews.apache.org/r/42180/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 42180: FALCON-1733: Support for building falcon
with JDK 1.8 also.
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42180/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 11:32 a.m.)
Review request for Falcon.
Bugs: FALCON-1733
https://issues.apache.org/jira/browse/FALCON-1733
Repository: falcon-git
Description
-------
Currently, the falcon build fails with JDK 1.8. This is because many of the plugins still points to the older version, which will need to be updated.
Diffs (updated)
-----
checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e
client/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90
client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java cebf968
client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 7caacb5
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 575ceb3
common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java cf27408
common/src/main/java/org/apache/falcon/util/HdfsClassLoader.java 3f9091f
docs/src/site/twiki/InstallationSteps.twiki e8c76f7
metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b24292c
oozie/src/main/java/org/apache/falcon/logging/JobLogMover.java 830641e
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java 49fb4f7
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 07eb47c
oozie/src/main/java/org/apache/oozie/client/ProxyOozieClient.java fcd8ca7
pom.xml 39ee9ac
prism/src/main/java/org/apache/falcon/FalconServer.java d50ebe5
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java c32123d
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8ffecd8
replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java e97e84e
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bffdb0b
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java 7bee592
webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 056c0a1
Diff: https://reviews.apache.org/r/42180/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal