[GitHub] [poi] gffloodg commented on a diff in pull request #409: Textruns not honouring highlight

[GitBox <gi...@apache.org>]

gffloodg commented on code in PR #409:
URL: https://github.com/apache/poi/pull/409#discussion_r1056419343


##########
poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFTextRun.java:
##########
@@ -440,6 +440,23 @@ public void setFontColor(PaintStyle color) {
         setFontColor(rgb);
     }
 
+
+    @Override
+    public PaintStyle getHighlightColor() {
+        return null;
+    }
+
+    @Override
+    public void setHighlightColor(final Color color) {

Review Comment:
   I agree, but the common rendering in DrawTextParagraph does not have access to the XSLF* classes, so cannot be cast - I chose this as a tradeoff. If you have a better suggestion then Im happy to adjust as needed.



##########
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java:
##########
@@ -157,6 +160,52 @@ private static void fetchFontColor(CTTextCharacterProperties props, Consumer<Pai
         }
     }
 
+    @Override

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org