You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/03/20 02:47:02 UTC
svn commit: r520211 - in /mina:
branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
Author: trustin
Date: Mon Mar 19 18:47:00 2007
New Revision: 520211
URL: http://svn.apache.org/viewvc?view=rev&rev=520211
Log:
Resolved issue: DIRMINA-358 (default implementation of exceptionCaught in IOHandlerAdapter eats exceptions)
* Changed the default exceptionCaught() implementation to log the caught exception
Modified:
mina/branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
mina/branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
mina/trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
Modified: mina/branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
URL: http://svn.apache.org/viewvc/mina/branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java?view=diff&rev=520211&r1=520210&r2=520211
==============================================================================
--- mina/branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java (original)
+++ mina/branches/1.0/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java Mon Mar 19 18:47:00 2007
@@ -19,6 +19,7 @@
*/
package org.apache.mina.common;
+import org.apache.mina.util.SessionLog;
import org.apache.mina.util.SessionUtil;
/**
@@ -50,6 +51,15 @@
public void exceptionCaught( IoSession session, Throwable cause ) throws Exception
{
+ if( SessionLog.isWarnEnabled( session ) )
+ {
+ SessionLog.warn(
+ session,
+ "EXCEPTION, please override " +
+ IoHandlerAdapter.class.getSimpleName() +
+ ".exceptionCaught() for proper handling:",
+ cause );
+ }
}
public void messageReceived( IoSession session, Object message ) throws Exception
Modified: mina/branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
URL: http://svn.apache.org/viewvc/mina/branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java?view=diff&rev=520211&r1=520210&r2=520211
==============================================================================
--- mina/branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java (original)
+++ mina/branches/1.1/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java Mon Mar 19 18:47:00 2007
@@ -19,6 +19,7 @@
*/
package org.apache.mina.common;
+import org.apache.mina.util.SessionLog;
import org.apache.mina.util.SessionUtil;
/**
@@ -50,6 +51,15 @@
public void exceptionCaught( IoSession session, Throwable cause ) throws Exception
{
+ if( SessionLog.isWarnEnabled( session ) )
+ {
+ SessionLog.warn(
+ session,
+ "EXCEPTION, please override " +
+ IoHandlerAdapter.class.getSimpleName() +
+ ".exceptionCaught() for proper handling:",
+ cause );
+ }
}
public void messageReceived( IoSession session, Object message ) throws Exception
Modified: mina/trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java?view=diff&rev=520211&r1=520210&r2=520211
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/common/IoHandlerAdapter.java Mon Mar 19 18:47:00 2007
@@ -19,6 +19,7 @@
*/
package org.apache.mina.common;
+import org.apache.mina.util.SessionLog;
import org.apache.mina.util.SessionUtil;
/**
@@ -50,6 +51,15 @@
public void exceptionCaught( IoSession session, Throwable cause ) throws Exception
{
+ if( SessionLog.isWarnEnabled( session ) )
+ {
+ SessionLog.warn(
+ session,
+ "EXCEPTION, please override " +
+ IoHandlerAdapter.class.getSimpleName() +
+ ".exceptionCaught() for proper handling:",
+ cause );
+ }
}
public void messageReceived( IoSession session, Object message ) throws Exception