You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "tanishq-chugh (via GitHub)" <gi...@apache.org> on 2026/10/05 06:45:08 UTC
[PR] [WIP] HIVE-30134: Structured error codes for persistable session failover [hive]
tanishq-chugh opened a new pull request, #6847:
URL: https://github.com/apache/hive/pull/6847
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducible example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-30134: Structured error codes for persistable session failover [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6847:
URL: https://github.com/apache/hive/pull/6847#issuecomment-6004291946
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6847) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6847&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6847&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6847&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6847&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6847&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6847)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-30134: Structured error codes for persistable session failover [hive]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6847:
URL: https://github.com/apache/hive/pull/6847#discussion_r4181442433
##########
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java:
##########
@@ -246,37 +252,10 @@ private boolean checkInvalidOperationHandle(TCloseOperationResp closeResp) {
if (status == null) {
return false;
}
- if (status.isSetErrorMessage()) {
- String errorMsg = status.getErrorMessage();
- if (errorMsg.contains("Invalid OperationHandle") || errorMsg.contains("Operation does not exist")) {
- LOG.warn("Ignoring benign close operation error: {}", errorMsg);
- return true;
- }
- }
- List<String> messages = status.getInfoMessages();
- if (messages != null && !messages.isEmpty()) {
- /*
- * Here we need to handle 2 different cases, which can happen in CLIService.closeOperation, which actually does:
- * sessionManager.getOperationManager().getOperation(opHandle).getParentSession().closeOperation(opHandle);
- */
- String message = messages.getFirst();
- if (message.contains("Invalid OperationHandle")) {
- /*
- * This happens when the first request properly removes the operation handle, then second request arrives, calls
- * sessionManager.getOperationManager().getOperation(opHandle), and it doesn't find the handle.
- */
- LOG.warn("'Invalid OperationHandle' on server side (messages: " + messages + ")");
- return true;
- } else if (message.contains("Operation does not exist")) {
- /*
- * This is an extremely rare case, which represents a race condition when the first and second request
- * arrives almost at the same time, both can get the OperationHandle instance
- * from sessionManager's OperationManager, but the second fails, because it cannot get it again from the
- * session's OperationManager, because it has been already removed in the meantime.
- */
- LOG.warn("'Operation does not exist' on server side (messages: " + messages + ")");
- return true;
- }
+ if (status.getErrorCode() == ErrorMsg.INVALID_OPERATION_HANDLE.getErrorCode() ||
+ status.getErrorCode() == ErrorMsg.OPERATION_NOT_EXIST.getErrorCode()) {
+ LOG.warn("Ignoring benign close operation error: {}", status.getErrorMessage());
+ return true;
}
Review Comment:
This drops compatibility with HS2 versions that predate these vendor codes. Such servers return these benign duplicate-close failures with error code 0/unset and put the text in `errorMessage` or `infoMessages`; the JDBC client will now pass the response to `verifySuccessWithInfo` and fail the close. Keep the code checks as the primary path, but retain the legacy message fallback (and cover a code-0 response in the test).
This issue also appears in the following locations of the same file:
- line 409
- line 573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-30134: Structured error codes for persistable session failover [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6847:
URL: https://github.com/apache/hive/pull/6847#issuecomment-5990287768
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6847) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6847&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6847&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6847&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6847&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6847&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6847)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org