You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Andrei Sereda <as...@gmail.com> on 2022/07/23 03:07:47 UTC
[VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.31.0, release
candidate 0.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
Its hash is c416e109460d8e439078206a48057b504b6bb08b
Tag:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
(revision 55918)
The hashes of the artifacts are as follows:
527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
*apache-calcite-1.31.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/sereda.asc
https://www.apache.org/dist/calcite/KEYS
To create the jars and test Apache Calcite: "gradle build"
(requires an appropriate Gradle/JDK installation)
Please vote on releasing this package as Apache Calcite 1.31.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.31.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (non-binding)
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Andrei Sereda <as...@gmail.com>.
I have started a separate thread for RC1.
Among fixes that have been discussed previously, it also includes new
Avatica version 1.22: CALCITE-5221
On Tue, Jul 26, 2022 at 6:33 PM Andrei Sereda <as...@gmail.com> wrote:
> Hello,
>
> Thanks for the detailed feedback.
>
> Regarding differences between git and src releases (empty folders reported
> by Stamatis) it is indeed a stale state of my branch. It is the main reason
> I'd like to make a clean (RC1) release candidate.
>
> Some answers to Julian's notes:
>
> > 1. It's strange that the release notes contain a blank section for
> 1.32 already. Probably better to add that section only after the
> release.
>
> 1.32 history section is being added as a jekyll comment and is not visible
> on the public site. It is done to help the next RM. When I started a draft
> for history notes, a similar section was already prepared for 1.31.
>
> Agree that it is better to add if after the release.
>
>
> > 2. It would be useful if the breaking changes section said what about
> > CALCITE-4936 was breaking (In the bug, Statmatis wrote "Old behavior:
> > The Project operator is transformed into Calc. New behavior: The
> > Project operator is not transformed and the rule becomes NOOP.")
>
> Thanks. Will update the notes.
>
> > 4. It's ironic that the boilerplate has changed from "Contributors to
> > this release" in 1.30 to "Thanks to all contributors (in alphabetical
> > order)" in this release and yet the list of contributors is not in
> > alphabetical order.
>
> Thanks for pointing it out.
>
>
> > 5. The build gives some scary warnings. We should fix these shortly.
>
> I will check if it is easily fixable.
>
>
> Overall I'm inclined to create RC1 mainly because of issues reported by
> Stamatis. Let me know if you agree.
>
> Thanks,
> Andrei.
>
> On Mon, Jul 25, 2022 at 8:22 PM Julian Hyde <jh...@apache.org> wrote:
>
>> Andrei, Thank you for being release manager!
>>
>> Downloaded, checked signatures & checksums, LICENSE, NOTICE, howto.md;
>> compiled and ran tests using OpenJDK 18 and Gradle-7.4.2 on Ubuntu
>> Linux.
>>
>> My vote is 0 (binding) due to the arrow and .mvn directories noted by
>> Stamatis. I will change my vote to +1 if we have an explanation of why
>> these files exist and a plan to prevent them in future RCs.
>>
>> Julian
>>
>>
>> Notes:
>>
>> 1. It's strange that the release notes contain a blank section for
>> 1.32 already. Probably better to add that section only after the
>> release.
>>
>> 2. It would be useful if the breaking changes section said what about
>> CALCITE-4936 was breaking (In the bug, Statmatis wrote "Old behavior:
>> The Project operator is transformed into Calc. New behavior: The
>> Project operator is not transformed and the rule becomes NOOP.")
>>
>> 3. Andrei, you should have added yourself ("Andrei Sereda (release
>> manager)") to the list of contributors.
>>
>> 4. It's ironic that the boilerplate has changed from "Contributors to
>> this release" in 1.30 to "Thanks to all contributors (in alphabetical
>> order)" in this release and yet the list of contributors is not in
>> alphabetical order.
>>
>> 5. The build gives some scary warnings. We should fix these shortly.
>>
>> > Configure project :buildSrc
>> Could not load entry 7b753dfea6780c3d32cd7106d24999f8 from remote
>> build cache: Bucket 'calcite-gradle-cache' not found
>>
>> > Task :buildSrc:buildext:compileKotlin
>> 'compileJava' task (current target is 18) and 'compileKotlin' task
>> (current target is 1.8) jvm target compatibility should be set to the
>> same Java version.
>>
>> > Task :buildSrc:javacc:compileKotlin
>> 'compileJava' task (current target is 18) and 'compileKotlin' task
>> (current target is 1.8) jvm target compatibility should be set to the
>> same Java version.
>>
>> w:
>> /tmp/apache-calcite-1.31.0-src/buildSrc/subprojects/javacc/src/main/kotlin/org/apache/calcite/buildtools/javacc/JavaCCTask.kt:
>> (66, 13): 'setter for main: String?' is deprecated. Deprecated in Java
>>
>> > Task :buildSrc:fmpp:compileKotlin
>> 'compileJava' task (current target is 18) and 'compileKotlin' task
>> (current target is 1.8) jvm target compatibility should be set to the
>> same Java version.
>>
>> On Mon, Jul 25, 2022 at 9:07 AM Stamatis Zampetakis <za...@gmail.com>
>> wrote:
>> >
>> > Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2
>> >
>> > * Checked signatures and checksums OK
>> > * Went over release note OK (left some comments in the draft PR)
>> > * Built from git tag and run tests (./gradlew clean build) OK
>> > * Built from source artifacts and run unit tests + slow tests OK
>> > * Checked diff between git repo and release sources KO
>> >
>> > Comparing the contents between the git repo and the release sources I
>> found
>> > that the (RC0) sources contain two (empty) directories (i.e., arrow,
>> .mvn)
>> > that shouldn't be there.
>> > I guess there was some kind of stale state in the calcite directory when
>> > preparing the RC. The command that I used to compare the sources can be
>> > found below.
>> >
>> > $ diff -qr apache-calcite-1.31.0-src apache-calcite-1.31.0-git
>> > Only in apache-calcite-1.31.0-src: arrow
>> > Only in apache-calcite-1.31.0-git: .git
>> > Only in apache-calcite-1.31.0-git/gradle: wrapper
>> > Only in apache-calcite-1.31.0-git: gradlew
>> > Only in apache-calcite-1.31.0-git: gradlew.bat
>> > Only in apache-calcite-1.31.0-src: licenses
>> > Only in apache-calcite-1.31.0-src: .mvn
>> > Only in apache-calcite-1.31.0-git/site: fonts
>> >
>> > The rest of the differences look normal and have been discussed
>> previously.
>> >
>> > 0 (binding)
>> >
>> > Best,
>> > Stamatis
>> >
>> > On Mon, Jul 25, 2022 at 2:46 AM Francis Chuang <
>> francischuang@apache.org>
>> > wrote:
>> >
>> > > Thanks for being RM for this release, Andrei.
>> > >
>> > > My vote is: +1 (binding)
>> > >
>> > > - Verified GPG signature - OK
>> > > - Verified SHA512 - OK
>> > > - Checked release notes on tag
>> > > (
>> > >
>> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
>> )
>> > >
>> > > - OK
>> > > - Ran tests (gradle check) - OK
>> > > - Spot checked Nexus artifacts - OK
>> > >
>> > > Environment:
>> > > Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
>> > > Windows 10 21h2
>> > >
>> > > > docker version
>> > > Client: Docker Engine - Community
>> > > Cloud integration: v1.0.24
>> > > Version: 20.10.17
>> > > API version: 1.41
>> > > Go version: go1.17.11
>> > > Git commit: 100c701
>> > > Built: Mon Jun 6 23:03:17 2022
>> > > OS/Arch: linux/amd64
>> > > Context: default
>> > > Experimental: true
>> > >
>> > > Server: Docker Desktop
>> > > Engine:
>> > > Version: 20.10.17
>> > > API version: 1.41 (minimum version 1.12)
>> > > Go version: go1.17.11
>> > > Git commit: a89b842
>> > > Built: Mon Jun 6 23:01:23 2022
>> > > OS/Arch: linux/amd64
>> > > Experimental: false
>> > > containerd:
>> > > Version: 1.6.6
>> > > GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
>> > > runc:
>> > > Version: 1.1.2
>> > > GitCommit: v1.1.2-0-ga916309
>> > > docker-init:
>> > > Version: 0.19.0
>> > > GitCommit: de40ad0
>> > >
>> > > > gradle -v
>> > >
>> > > ------------------------------------------------------------
>> > > Gradle 7.4.2
>> > > ------------------------------------------------------------
>> > >
>> > > Build time: 2022-03-31 15:25:29 UTC
>> > > Revision: 540473b8118064efcc264694cbcaa4b677f61041
>> > >
>> > > Kotlin: 1.5.31
>> > > Groovy: 3.0.9
>> > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
>> > > JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
>> > > OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
>> > >
>> > > > java -version
>> > > openjdk version "17.0.3" 2022-04-19
>> > > OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
>> > > OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
>> > > sharing)
>> > >
>> > > Regarding the java aggregate docs pointed out by Benchao: I think it
>> > > should be fine after they are automatically deployed when the release
>> is
>> > > finalized. The previous version's website was manually deployed, so I
>> > > think there was a small error in the deployment.
>> > >
>> > > Francis
>> > >
>> > > On 23/07/2022 1:07 pm, Andrei Sereda wrote:
>> > > > Hi all,
>> > > >
>> > > > I have created a build for Apache Calcite 1.31.0, release
>> > > > candidate 0.
>> > > >
>> > > > Thanks to everyone who has contributed to this release.
>> > > >
>> > > > You can read the release notes here:
>> > > >
>> > >
>> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
>> > > >
>> > > > The commit to be voted upon:
>> > > >
>> > >
>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
>> > > >
>> > > > Its hash is c416e109460d8e439078206a48057b504b6bb08b
>> > > >
>> > > > Tag:
>> > > >
>> > >
>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
>> > > >
>> > > > The artifacts to be voted on are located here:
>> > > >
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
>> > > > (revision 55918)
>> > > >
>> > > > The hashes of the artifacts are as follows:
>> > > >
>> > >
>> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
>> > > > *apache-calcite-1.31.0-src.tar.gz
>> > > >
>> > > > A staged Maven repository is available for review at:
>> > > >
>> > >
>> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
>> > > >
>> > > > Release artifacts are signed with the following key:
>> > > > https://people.apache.org/keys/committer/sereda.asc
>> > > > https://www.apache.org/dist/calcite/KEYS
>> > > >
>> > > > To create the jars and test Apache Calcite: "gradle build"
>> > > > (requires an appropriate Gradle/JDK installation)
>> > > >
>> > > > Please vote on releasing this package as Apache Calcite 1.31.0.
>> > > >
>> > > > The vote is open for the next 72 hours and passes if a majority of
>> at
>> > > > least three +1 PMC votes are cast.
>> > > >
>> > > > [ ] +1 Release this package as Apache Calcite 1.31.0
>> > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
>> > > > [ ] -1 Do not release this package because...
>> > > >
>> > > > Here is my vote:
>> > > >
>> > > > +1 (non-binding)
>> > > >
>> > >
>>
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Julian Hyde <jh...@gmail.com>.
> Andrei wrote:
>
> 1.32 history section is being added as a jekyll comment and is not visible
> on the public site
Oops, my bad. I didn’t notice the comment markers. I should have reviewed more carefully. I think it’s fine to leave it in.
> Overall I'm inclined to create RC1 mainly because of issues reported by
> Stamatis. Let me know if you agree.
Yes, I agree. Especially in light of the new Avatica release.
But please send a ‘[CANCEL]’ or ‘[RESULT]’ email to close this thread.
Julian
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Andrei Sereda <as...@gmail.com>.
Hello,
Thanks for the detailed feedback.
Regarding differences between git and src releases (empty folders reported
by Stamatis) it is indeed a stale state of my branch. It is the main reason
I'd like to make a clean (RC1) release candidate.
Some answers to Julian's notes:
> 1. It's strange that the release notes contain a blank section for
1.32 already. Probably better to add that section only after the
release.
1.32 history section is being added as a jekyll comment and is not visible
on the public site. It is done to help the next RM. When I started a draft
for history notes, a similar section was already prepared for 1.31.
Agree that it is better to add if after the release.
> 2. It would be useful if the breaking changes section said what about
> CALCITE-4936 was breaking (In the bug, Statmatis wrote "Old behavior:
> The Project operator is transformed into Calc. New behavior: The
> Project operator is not transformed and the rule becomes NOOP.")
Thanks. Will update the notes.
> 4. It's ironic that the boilerplate has changed from "Contributors to
> this release" in 1.30 to "Thanks to all contributors (in alphabetical
> order)" in this release and yet the list of contributors is not in
> alphabetical order.
Thanks for pointing it out.
> 5. The build gives some scary warnings. We should fix these shortly.
I will check if it is easily fixable.
Overall I'm inclined to create RC1 mainly because of issues reported by
Stamatis. Let me know if you agree.
Thanks,
Andrei.
On Mon, Jul 25, 2022 at 8:22 PM Julian Hyde <jh...@apache.org> wrote:
> Andrei, Thank you for being release manager!
>
> Downloaded, checked signatures & checksums, LICENSE, NOTICE, howto.md;
> compiled and ran tests using OpenJDK 18 and Gradle-7.4.2 on Ubuntu
> Linux.
>
> My vote is 0 (binding) due to the arrow and .mvn directories noted by
> Stamatis. I will change my vote to +1 if we have an explanation of why
> these files exist and a plan to prevent them in future RCs.
>
> Julian
>
>
> Notes:
>
> 1. It's strange that the release notes contain a blank section for
> 1.32 already. Probably better to add that section only after the
> release.
>
> 2. It would be useful if the breaking changes section said what about
> CALCITE-4936 was breaking (In the bug, Statmatis wrote "Old behavior:
> The Project operator is transformed into Calc. New behavior: The
> Project operator is not transformed and the rule becomes NOOP.")
>
> 3. Andrei, you should have added yourself ("Andrei Sereda (release
> manager)") to the list of contributors.
>
> 4. It's ironic that the boilerplate has changed from "Contributors to
> this release" in 1.30 to "Thanks to all contributors (in alphabetical
> order)" in this release and yet the list of contributors is not in
> alphabetical order.
>
> 5. The build gives some scary warnings. We should fix these shortly.
>
> > Configure project :buildSrc
> Could not load entry 7b753dfea6780c3d32cd7106d24999f8 from remote
> build cache: Bucket 'calcite-gradle-cache' not found
>
> > Task :buildSrc:buildext:compileKotlin
> 'compileJava' task (current target is 18) and 'compileKotlin' task
> (current target is 1.8) jvm target compatibility should be set to the
> same Java version.
>
> > Task :buildSrc:javacc:compileKotlin
> 'compileJava' task (current target is 18) and 'compileKotlin' task
> (current target is 1.8) jvm target compatibility should be set to the
> same Java version.
>
> w:
> /tmp/apache-calcite-1.31.0-src/buildSrc/subprojects/javacc/src/main/kotlin/org/apache/calcite/buildtools/javacc/JavaCCTask.kt:
> (66, 13): 'setter for main: String?' is deprecated. Deprecated in Java
>
> > Task :buildSrc:fmpp:compileKotlin
> 'compileJava' task (current target is 18) and 'compileKotlin' task
> (current target is 1.8) jvm target compatibility should be set to the
> same Java version.
>
> On Mon, Jul 25, 2022 at 9:07 AM Stamatis Zampetakis <za...@gmail.com>
> wrote:
> >
> > Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2
> >
> > * Checked signatures and checksums OK
> > * Went over release note OK (left some comments in the draft PR)
> > * Built from git tag and run tests (./gradlew clean build) OK
> > * Built from source artifacts and run unit tests + slow tests OK
> > * Checked diff between git repo and release sources KO
> >
> > Comparing the contents between the git repo and the release sources I
> found
> > that the (RC0) sources contain two (empty) directories (i.e., arrow,
> .mvn)
> > that shouldn't be there.
> > I guess there was some kind of stale state in the calcite directory when
> > preparing the RC. The command that I used to compare the sources can be
> > found below.
> >
> > $ diff -qr apache-calcite-1.31.0-src apache-calcite-1.31.0-git
> > Only in apache-calcite-1.31.0-src: arrow
> > Only in apache-calcite-1.31.0-git: .git
> > Only in apache-calcite-1.31.0-git/gradle: wrapper
> > Only in apache-calcite-1.31.0-git: gradlew
> > Only in apache-calcite-1.31.0-git: gradlew.bat
> > Only in apache-calcite-1.31.0-src: licenses
> > Only in apache-calcite-1.31.0-src: .mvn
> > Only in apache-calcite-1.31.0-git/site: fonts
> >
> > The rest of the differences look normal and have been discussed
> previously.
> >
> > 0 (binding)
> >
> > Best,
> > Stamatis
> >
> > On Mon, Jul 25, 2022 at 2:46 AM Francis Chuang <francischuang@apache.org
> >
> > wrote:
> >
> > > Thanks for being RM for this release, Andrei.
> > >
> > > My vote is: +1 (binding)
> > >
> > > - Verified GPG signature - OK
> > > - Verified SHA512 - OK
> > > - Checked release notes on tag
> > > (
> > >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> )
> > >
> > > - OK
> > > - Ran tests (gradle check) - OK
> > > - Spot checked Nexus artifacts - OK
> > >
> > > Environment:
> > > Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
> > > Windows 10 21h2
> > >
> > > > docker version
> > > Client: Docker Engine - Community
> > > Cloud integration: v1.0.24
> > > Version: 20.10.17
> > > API version: 1.41
> > > Go version: go1.17.11
> > > Git commit: 100c701
> > > Built: Mon Jun 6 23:03:17 2022
> > > OS/Arch: linux/amd64
> > > Context: default
> > > Experimental: true
> > >
> > > Server: Docker Desktop
> > > Engine:
> > > Version: 20.10.17
> > > API version: 1.41 (minimum version 1.12)
> > > Go version: go1.17.11
> > > Git commit: a89b842
> > > Built: Mon Jun 6 23:01:23 2022
> > > OS/Arch: linux/amd64
> > > Experimental: false
> > > containerd:
> > > Version: 1.6.6
> > > GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
> > > runc:
> > > Version: 1.1.2
> > > GitCommit: v1.1.2-0-ga916309
> > > docker-init:
> > > Version: 0.19.0
> > > GitCommit: de40ad0
> > >
> > > > gradle -v
> > >
> > > ------------------------------------------------------------
> > > Gradle 7.4.2
> > > ------------------------------------------------------------
> > >
> > > Build time: 2022-03-31 15:25:29 UTC
> > > Revision: 540473b8118064efcc264694cbcaa4b677f61041
> > >
> > > Kotlin: 1.5.31
> > > Groovy: 3.0.9
> > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > > JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
> > > OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
> > >
> > > > java -version
> > > openjdk version "17.0.3" 2022-04-19
> > > OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
> > > OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
> > > sharing)
> > >
> > > Regarding the java aggregate docs pointed out by Benchao: I think it
> > > should be fine after they are automatically deployed when the release
> is
> > > finalized. The previous version's website was manually deployed, so I
> > > think there was a small error in the deployment.
> > >
> > > Francis
> > >
> > > On 23/07/2022 1:07 pm, Andrei Sereda wrote:
> > > > Hi all,
> > > >
> > > > I have created a build for Apache Calcite 1.31.0, release
> > > > candidate 0.
> > > >
> > > > Thanks to everyone who has contributed to this release.
> > > >
> > > > You can read the release notes here:
> > > >
> > >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> > > >
> > > > The commit to be voted upon:
> > > >
> > >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
> > > >
> > > > Its hash is c416e109460d8e439078206a48057b504b6bb08b
> > > >
> > > > Tag:
> > > >
> > >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
> > > >
> > > > The artifacts to be voted on are located here:
> > > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> > > > (revision 55918)
> > > >
> > > > The hashes of the artifacts are as follows:
> > > >
> > >
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> > > > *apache-calcite-1.31.0-src.tar.gz
> > > >
> > > > A staged Maven repository is available for review at:
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
> > > >
> > > > Release artifacts are signed with the following key:
> > > > https://people.apache.org/keys/committer/sereda.asc
> > > > https://www.apache.org/dist/calcite/KEYS
> > > >
> > > > To create the jars and test Apache Calcite: "gradle build"
> > > > (requires an appropriate Gradle/JDK installation)
> > > >
> > > > Please vote on releasing this package as Apache Calcite 1.31.0.
> > > >
> > > > The vote is open for the next 72 hours and passes if a majority of at
> > > > least three +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Calcite 1.31.0
> > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > > > Here is my vote:
> > > >
> > > > +1 (non-binding)
> > > >
> > >
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Andrei, Thank you for being release manager!
Downloaded, checked signatures & checksums, LICENSE, NOTICE, howto.md;
compiled and ran tests using OpenJDK 18 and Gradle-7.4.2 on Ubuntu
Linux.
My vote is 0 (binding) due to the arrow and .mvn directories noted by
Stamatis. I will change my vote to +1 if we have an explanation of why
these files exist and a plan to prevent them in future RCs.
Julian
Notes:
1. It's strange that the release notes contain a blank section for
1.32 already. Probably better to add that section only after the
release.
2. It would be useful if the breaking changes section said what about
CALCITE-4936 was breaking (In the bug, Statmatis wrote "Old behavior:
The Project operator is transformed into Calc. New behavior: The
Project operator is not transformed and the rule becomes NOOP.")
3. Andrei, you should have added yourself ("Andrei Sereda (release
manager)") to the list of contributors.
4. It's ironic that the boilerplate has changed from "Contributors to
this release" in 1.30 to "Thanks to all contributors (in alphabetical
order)" in this release and yet the list of contributors is not in
alphabetical order.
5. The build gives some scary warnings. We should fix these shortly.
> Configure project :buildSrc
Could not load entry 7b753dfea6780c3d32cd7106d24999f8 from remote
build cache: Bucket 'calcite-gradle-cache' not found
> Task :buildSrc:buildext:compileKotlin
'compileJava' task (current target is 18) and 'compileKotlin' task
(current target is 1.8) jvm target compatibility should be set to the
same Java version.
> Task :buildSrc:javacc:compileKotlin
'compileJava' task (current target is 18) and 'compileKotlin' task
(current target is 1.8) jvm target compatibility should be set to the
same Java version.
w: /tmp/apache-calcite-1.31.0-src/buildSrc/subprojects/javacc/src/main/kotlin/org/apache/calcite/buildtools/javacc/JavaCCTask.kt:
(66, 13): 'setter for main: String?' is deprecated. Deprecated in Java
> Task :buildSrc:fmpp:compileKotlin
'compileJava' task (current target is 18) and 'compileKotlin' task
(current target is 1.8) jvm target compatibility should be set to the
same Java version.
On Mon, Jul 25, 2022 at 9:07 AM Stamatis Zampetakis <za...@gmail.com> wrote:
>
> Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2
>
> * Checked signatures and checksums OK
> * Went over release note OK (left some comments in the draft PR)
> * Built from git tag and run tests (./gradlew clean build) OK
> * Built from source artifacts and run unit tests + slow tests OK
> * Checked diff between git repo and release sources KO
>
> Comparing the contents between the git repo and the release sources I found
> that the (RC0) sources contain two (empty) directories (i.e., arrow, .mvn)
> that shouldn't be there.
> I guess there was some kind of stale state in the calcite directory when
> preparing the RC. The command that I used to compare the sources can be
> found below.
>
> $ diff -qr apache-calcite-1.31.0-src apache-calcite-1.31.0-git
> Only in apache-calcite-1.31.0-src: arrow
> Only in apache-calcite-1.31.0-git: .git
> Only in apache-calcite-1.31.0-git/gradle: wrapper
> Only in apache-calcite-1.31.0-git: gradlew
> Only in apache-calcite-1.31.0-git: gradlew.bat
> Only in apache-calcite-1.31.0-src: licenses
> Only in apache-calcite-1.31.0-src: .mvn
> Only in apache-calcite-1.31.0-git/site: fonts
>
> The rest of the differences look normal and have been discussed previously.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> On Mon, Jul 25, 2022 at 2:46 AM Francis Chuang <fr...@apache.org>
> wrote:
>
> > Thanks for being RM for this release, Andrei.
> >
> > My vote is: +1 (binding)
> >
> > - Verified GPG signature - OK
> > - Verified SHA512 - OK
> > - Checked release notes on tag
> > (
> > https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md)
> >
> > - OK
> > - Ran tests (gradle check) - OK
> > - Spot checked Nexus artifacts - OK
> >
> > Environment:
> > Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
> > Windows 10 21h2
> >
> > > docker version
> > Client: Docker Engine - Community
> > Cloud integration: v1.0.24
> > Version: 20.10.17
> > API version: 1.41
> > Go version: go1.17.11
> > Git commit: 100c701
> > Built: Mon Jun 6 23:03:17 2022
> > OS/Arch: linux/amd64
> > Context: default
> > Experimental: true
> >
> > Server: Docker Desktop
> > Engine:
> > Version: 20.10.17
> > API version: 1.41 (minimum version 1.12)
> > Go version: go1.17.11
> > Git commit: a89b842
> > Built: Mon Jun 6 23:01:23 2022
> > OS/Arch: linux/amd64
> > Experimental: false
> > containerd:
> > Version: 1.6.6
> > GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
> > runc:
> > Version: 1.1.2
> > GitCommit: v1.1.2-0-ga916309
> > docker-init:
> > Version: 0.19.0
> > GitCommit: de40ad0
> >
> > > gradle -v
> >
> > ------------------------------------------------------------
> > Gradle 7.4.2
> > ------------------------------------------------------------
> >
> > Build time: 2022-03-31 15:25:29 UTC
> > Revision: 540473b8118064efcc264694cbcaa4b677f61041
> >
> > Kotlin: 1.5.31
> > Groovy: 3.0.9
> > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
> > OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
> >
> > > java -version
> > openjdk version "17.0.3" 2022-04-19
> > OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
> > OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
> > sharing)
> >
> > Regarding the java aggregate docs pointed out by Benchao: I think it
> > should be fine after they are automatically deployed when the release is
> > finalized. The previous version's website was manually deployed, so I
> > think there was a small error in the deployment.
> >
> > Francis
> >
> > On 23/07/2022 1:07 pm, Andrei Sereda wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.31.0, release
> > > candidate 0.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> > https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
> > >
> > > Its hash is c416e109460d8e439078206a48057b504b6bb08b
> > >
> > > Tag:
> > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> > > (revision 55918)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> > > *apache-calcite-1.31.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/sereda.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite: "gradle build"
> > > (requires an appropriate Gradle/JDK installation)
> > >
> > > Please vote on releasing this package as Apache Calcite 1.31.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.31.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (non-binding)
> > >
> >
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Ruben Q L <ru...@gmail.com>.
Thanks Andrei for being RM.
- Checksum and signature: ok
- Gradle test: ok
- Calcite-based application test suite: ok
- I confirm the diff issues already described by Stamatis, not sure if this
should be a blocking problem or not.
My vote is: 0 (binding)
Best,
Ruben
On Mon, Jul 25, 2022 at 5:07 PM Stamatis Zampetakis <za...@gmail.com>
wrote:
> Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2
>
> * Checked signatures and checksums OK
> * Went over release note OK (left some comments in the draft PR)
> * Built from git tag and run tests (./gradlew clean build) OK
> * Built from source artifacts and run unit tests + slow tests OK
> * Checked diff between git repo and release sources KO
>
> Comparing the contents between the git repo and the release sources I found
> that the (RC0) sources contain two (empty) directories (i.e., arrow, .mvn)
> that shouldn't be there.
> I guess there was some kind of stale state in the calcite directory when
> preparing the RC. The command that I used to compare the sources can be
> found below.
>
> $ diff -qr apache-calcite-1.31.0-src apache-calcite-1.31.0-git
> Only in apache-calcite-1.31.0-src: arrow
> Only in apache-calcite-1.31.0-git: .git
> Only in apache-calcite-1.31.0-git/gradle: wrapper
> Only in apache-calcite-1.31.0-git: gradlew
> Only in apache-calcite-1.31.0-git: gradlew.bat
> Only in apache-calcite-1.31.0-src: licenses
> Only in apache-calcite-1.31.0-src: .mvn
> Only in apache-calcite-1.31.0-git/site: fonts
>
> The rest of the differences look normal and have been discussed previously.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> On Mon, Jul 25, 2022 at 2:46 AM Francis Chuang <fr...@apache.org>
> wrote:
>
> > Thanks for being RM for this release, Andrei.
> >
> > My vote is: +1 (binding)
> >
> > - Verified GPG signature - OK
> > - Verified SHA512 - OK
> > - Checked release notes on tag
> > (
> >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> )
> >
> > - OK
> > - Ran tests (gradle check) - OK
> > - Spot checked Nexus artifacts - OK
> >
> > Environment:
> > Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
> > Windows 10 21h2
> >
> > > docker version
> > Client: Docker Engine - Community
> > Cloud integration: v1.0.24
> > Version: 20.10.17
> > API version: 1.41
> > Go version: go1.17.11
> > Git commit: 100c701
> > Built: Mon Jun 6 23:03:17 2022
> > OS/Arch: linux/amd64
> > Context: default
> > Experimental: true
> >
> > Server: Docker Desktop
> > Engine:
> > Version: 20.10.17
> > API version: 1.41 (minimum version 1.12)
> > Go version: go1.17.11
> > Git commit: a89b842
> > Built: Mon Jun 6 23:01:23 2022
> > OS/Arch: linux/amd64
> > Experimental: false
> > containerd:
> > Version: 1.6.6
> > GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
> > runc:
> > Version: 1.1.2
> > GitCommit: v1.1.2-0-ga916309
> > docker-init:
> > Version: 0.19.0
> > GitCommit: de40ad0
> >
> > > gradle -v
> >
> > ------------------------------------------------------------
> > Gradle 7.4.2
> > ------------------------------------------------------------
> >
> > Build time: 2022-03-31 15:25:29 UTC
> > Revision: 540473b8118064efcc264694cbcaa4b677f61041
> >
> > Kotlin: 1.5.31
> > Groovy: 3.0.9
> > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
> > OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
> >
> > > java -version
> > openjdk version "17.0.3" 2022-04-19
> > OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
> > OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
> > sharing)
> >
> > Regarding the java aggregate docs pointed out by Benchao: I think it
> > should be fine after they are automatically deployed when the release is
> > finalized. The previous version's website was manually deployed, so I
> > think there was a small error in the deployment.
> >
> > Francis
> >
> > On 23/07/2022 1:07 pm, Andrei Sereda wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.31.0, release
> > > candidate 0.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
> > >
> > > Its hash is c416e109460d8e439078206a48057b504b6bb08b
> > >
> > > Tag:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> > > (revision 55918)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> >
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> > > *apache-calcite-1.31.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/sereda.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite: "gradle build"
> > > (requires an appropriate Gradle/JDK installation)
> > >
> > > Please vote on releasing this package as Apache Calcite 1.31.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.31.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (non-binding)
> > >
> >
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Stamatis Zampetakis <za...@gmail.com>.
Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2
* Checked signatures and checksums OK
* Went over release note OK (left some comments in the draft PR)
* Built from git tag and run tests (./gradlew clean build) OK
* Built from source artifacts and run unit tests + slow tests OK
* Checked diff between git repo and release sources KO
Comparing the contents between the git repo and the release sources I found
that the (RC0) sources contain two (empty) directories (i.e., arrow, .mvn)
that shouldn't be there.
I guess there was some kind of stale state in the calcite directory when
preparing the RC. The command that I used to compare the sources can be
found below.
$ diff -qr apache-calcite-1.31.0-src apache-calcite-1.31.0-git
Only in apache-calcite-1.31.0-src: arrow
Only in apache-calcite-1.31.0-git: .git
Only in apache-calcite-1.31.0-git/gradle: wrapper
Only in apache-calcite-1.31.0-git: gradlew
Only in apache-calcite-1.31.0-git: gradlew.bat
Only in apache-calcite-1.31.0-src: licenses
Only in apache-calcite-1.31.0-src: .mvn
Only in apache-calcite-1.31.0-git/site: fonts
The rest of the differences look normal and have been discussed previously.
0 (binding)
Best,
Stamatis
On Mon, Jul 25, 2022 at 2:46 AM Francis Chuang <fr...@apache.org>
wrote:
> Thanks for being RM for this release, Andrei.
>
> My vote is: +1 (binding)
>
> - Verified GPG signature - OK
> - Verified SHA512 - OK
> - Checked release notes on tag
> (
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md)
>
> - OK
> - Ran tests (gradle check) - OK
> - Spot checked Nexus artifacts - OK
>
> Environment:
> Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
> Windows 10 21h2
>
> > docker version
> Client: Docker Engine - Community
> Cloud integration: v1.0.24
> Version: 20.10.17
> API version: 1.41
> Go version: go1.17.11
> Git commit: 100c701
> Built: Mon Jun 6 23:03:17 2022
> OS/Arch: linux/amd64
> Context: default
> Experimental: true
>
> Server: Docker Desktop
> Engine:
> Version: 20.10.17
> API version: 1.41 (minimum version 1.12)
> Go version: go1.17.11
> Git commit: a89b842
> Built: Mon Jun 6 23:01:23 2022
> OS/Arch: linux/amd64
> Experimental: false
> containerd:
> Version: 1.6.6
> GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
> runc:
> Version: 1.1.2
> GitCommit: v1.1.2-0-ga916309
> docker-init:
> Version: 0.19.0
> GitCommit: de40ad0
>
> > gradle -v
>
> ------------------------------------------------------------
> Gradle 7.4.2
> ------------------------------------------------------------
>
> Build time: 2022-03-31 15:25:29 UTC
> Revision: 540473b8118064efcc264694cbcaa4b677f61041
>
> Kotlin: 1.5.31
> Groovy: 3.0.9
> Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
> OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
>
> > java -version
> openjdk version "17.0.3" 2022-04-19
> OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
> OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
> sharing)
>
> Regarding the java aggregate docs pointed out by Benchao: I think it
> should be fine after they are automatically deployed when the release is
> finalized. The previous version's website was manually deployed, so I
> think there was a small error in the deployment.
>
> Francis
>
> On 23/07/2022 1:07 pm, Andrei Sereda wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.31.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
> >
> > Its hash is c416e109460d8e439078206a48057b504b6bb08b
> >
> > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> > (revision 55918)
> >
> > The hashes of the artifacts are as follows:
> >
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> > *apache-calcite-1.31.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/sereda.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite: "gradle build"
> > (requires an appropriate Gradle/JDK installation)
> >
> > Please vote on releasing this package as Apache Calcite 1.31.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.31.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Here is my vote:
> >
> > +1 (non-binding)
> >
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Francis Chuang <fr...@apache.org>.
Thanks for being RM for this release, Andrei.
My vote is: +1 (binding)
- Verified GPG signature - OK
- Verified SHA512 - OK
- Checked release notes on tag
(https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md)
- OK
- Ran tests (gradle check) - OK
- Spot checked Nexus artifacts - OK
Environment:
Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 20.04) on
Windows 10 21h2
> docker version
Client: Docker Engine - Community
Cloud integration: v1.0.24
Version: 20.10.17
API version: 1.41
Go version: go1.17.11
Git commit: 100c701
Built: Mon Jun 6 23:03:17 2022
OS/Arch: linux/amd64
Context: default
Experimental: true
Server: Docker Desktop
Engine:
Version: 20.10.17
API version: 1.41 (minimum version 1.12)
Go version: go1.17.11
Git commit: a89b842
Built: Mon Jun 6 23:01:23 2022
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.6.6
GitCommit: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
runc:
Version: 1.1.2
GitCommit: v1.1.2-0-ga916309
docker-init:
Version: 0.19.0
GitCommit: de40ad0
> gradle -v
------------------------------------------------------------
Gradle 7.4.2
------------------------------------------------------------
Build time: 2022-03-31 15:25:29 UTC
Revision: 540473b8118064efcc264694cbcaa4b677f61041
Kotlin: 1.5.31
Groovy: 3.0.9
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 17.0.3 (Eclipse Adoptium 17.0.3+7)
OS: Linux 5.10.102.1-microsoft-standard-WSL2 amd64
> java -version
openjdk version "17.0.3" 2022-04-19
OpenJDK Runtime Environment Temurin-17.0.3+7 (build 17.0.3+7)
OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (build 17.0.3+7, mixed mode,
sharing)
Regarding the java aggregate docs pointed out by Benchao: I think it
should be fine after they are automatically deployed when the release is
finalized. The previous version's website was manually deployed, so I
think there was a small error in the deployment.
Francis
On 23/07/2022 1:07 pm, Andrei Sereda wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.31.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
>
> Its hash is c416e109460d8e439078206a48057b504b6bb08b
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> (revision 55918)
>
> The hashes of the artifacts are as follows:
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> *apache-calcite-1.31.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/sereda.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.31.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.31.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (non-binding)
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Benchao Li <li...@apache.org>.
+1 (non-binding)
- checked checksum and signatures: OK
- checked NOTICE/LICENSE in source and jar: OK
- build and test from source: OK
- build javadoc: OK
- checked with older guava versions(19.0): OK
Besides, I would like to bring up CALCITE-5092.
I checked our release process, and found that we did not have a checking
phase
before pushing the newly released javadoc to the calcite-site repo.
Hence I bring this to your attention, and it would be good to check whether
the
new release resolves CALCITE-5092. (I would like to help to check it if you
need)
[1] https://issues.apache.org/jira/browse/CALCITE-5092
Vova Vysotskyi <vo...@apache.org> 于2022年7月24日周日 17:28写道：
> Hi everyone,
>
> I have verified signatures for distribution, built it, run all unit tests,
> and no issues are found.
>
> Also, I have checked the new Calcite version with Apache Drill, and it
> works fine, all Drill unit tests also pass.
>
> +1 (binding)
>
> Kind regards,
> Volodymyr Vysotskyi
>
> On 2022/07/23 03:07:47 Andrei Sereda wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.31.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
> >
> > Its hash is c416e109460d8e439078206a48057b504b6bb08b
> >
> > Tag:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> > (revision 55918)
> >
> > The hashes of the artifacts are as follows:
> >
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> > *apache-calcite-1.31.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/sereda.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite: "gradle build"
> > (requires an appropriate Gradle/JDK installation)
> >
> > Please vote on releasing this package as Apache Calcite 1.31.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.31.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Here is my vote:
> >
> > +1 (non-binding)
> >
>
--
Best,
Benchao Li
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Vova Vysotskyi <vo...@apache.org>.
Hi everyone,
I have verified signatures for distribution, built it, run all unit tests, and no issues are found.
Also, I have checked the new Calcite version with Apache Drill, and it works fine, all Drill unit tests also pass.
+1 (binding)
Kind regards,
Volodymyr Vysotskyi
On 2022/07/23 03:07:47 Andrei Sereda wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.31.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
>
> Its hash is c416e109460d8e439078206a48057b504b6bb08b
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> (revision 55918)
>
> The hashes of the artifacts are as follows:
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> *apache-calcite-1.31.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/sereda.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.31.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.31.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (non-binding)
>
Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)
Posted by Alessandro Solimando <al...@gmail.com>.
Hello everyone,
thanks a lot Andrei for all the work behind this release, very much
appreciated.
My vote is +1 (non-binding) but I would like to highlight the differences I
noticed with respect to the tag when checked out from the git repo, it does
not look major but I don't remember seeing a similar difference in previous
releases.
- verified gpg signature: OK
$ gpg --verify apache-calcite-1.31.0-src.tar.gz.asc
apache-calcite-1.31.0-src.tar.gz
gpg: Signature made Sat 23 Jul 04:28:59 2022 CEST
gpg: using RSA key 25E703106B1B3D7B105032BDC41CFDDFED34C028
gpg: Good signature from "Andrei Sereda (CODE SIGNING KEY) <
sereda@apache.org>" [unknown]
gpg: aka "Andrei Sereda <an...@sereda.cc>" [unknown]
gpg: aka "Andrei Sereda <as...@gmail.com>" [unknown]
gpg: aka "asereda-gs (Andrei Sereda) <
25229979+asereda-gs@users.noreply.github.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 25E7 0310 6B1B 3D7B 1050 32BD C41C FDDF ED34 C028
(we agreed on previous releases that this warning is OK)
- verified package checksum: OK
$ diff <(cat apache-calcite-1.31.0-src.tar.gz.sha512) <(shasum -a 512
apache-calcite-1.31.0-src.tar.gz)
1c1
<
527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
*apache-calcite-1.31.0-src.tar.gz
---
>
527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
apache-calcite-1.31.0-src.tar.gz
- verified gradle build: OK
$ cp ~/git/calcite/gradlew .
$ cp -r ~/git/calcite/gradle/wrapper gradle
$ ./gradlew build
...
BUILD SUCCESSFUL in 4m 50s
- checked release notes: OK
- checked few artifacts in Apache repository: OK
- checking difference in folder: OK
$ diff -qr . ~/git/calcite | grep -v gradle | grep -v idea
1) Files ./README and /Users/asolimando/git/calcite/README differ
2) Only in .: licenses
3) Files ./site/_docs/history.md and
/Users/asolimando/git/calcite/site/_docs/history.md differ
4) Files ./site/_docs/howto.md and
/Users/asolimando/git/calcite/site/_docs/howto.md differ
5) Only in /Users/asolimando/git/calcite/site: fonts
2 and 5 are expected to me, I don't recall any differences for the other
files in previous releases, but I am not sure:
1)
$ diff ./README /Users/asolimando/git/calcite/README
1c1
< Apache Calcite release 1.31.0
---
> Apache Calcite release 1.30.0
3)
$ diff ./site/_docs/history.md
/Users/asolimando/git/calcite/site/_docs/history.md
> {: #dependency-1-31-0}
279a60
> {% endcomment %}
281,305d61
< * Site: Add Jing Zhang as committer
< * Site: Add Benchao Li as committer
< * Site: Add Chunwei Lei and Vladimir Ozerov as PMC members
< * Site: Outline process for becoming Calcite committer by request
< * Site: Remove missing avatar for Ted Dunning
< * Site: Fix release announcement for 1.30.0
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5075
">CALCITE-5075</a>]
< Build fails due to rat check on Gemfile.lock
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5079
">CALCITE-5079</a>]
< Update code demo of tutorial
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5102
">CALCITE-5102</a>]
< Update github-pages gem for site build
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5106
">CALCITE-5106</a>]
< Upgrade to Jekyll 4 and remove unnecessary dependencies from gemfile for
site
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5108
">CALCITE-5108</a>]
< Make website GDPR-compliant
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5110
">CALCITE-5110</a>]
< Geode adapter's java doc url is invalid
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5165
">CALCITE-5165</a>]
< Improve javadoc
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-3129
">CALCITE-3129</a>]
< Automate website builds
< * [<a href="https://issues.apache.org/jira/browse/CALCITE-5111
">CALCITE-5111</a>]
< jekyll-cache directory should be ignored by git
4)
$ diff ./site/_docs/howto.md
/Users/asolimando/git/calcite/site/_docs/howto.md
42,43c42,43
< $ tar xvfz apache-calcite-1.31.0-src.tar.gz
< $ cd apache-calcite-1.31.0-src
---
> $ tar xvfz apache-calcite-1.30.0-src.tar.gz
> $ cd apache-calcite-1.30.0-src
608c608
< * mark the appropriate version (e.g., 1.31.0) in the "Fix version" field;
---
> * mark the appropriate version (e.g., 1.30.0) in the "Fix version" field;
- environment used:
$ sw_vers
ProductName: macOS
ProductVersion: 11.6
BuildVersion: 20G165
$ ./gradlew -version
------------------------------------------------------------
Gradle 7.3
------------------------------------------------------------
Build time: 2021-11-09 20:40:36 UTC
Revision: 96754b8c44399658178a768ac764d727c2addb37
Kotlin: 1.5.31
Groovy: 3.0.9
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 1.8.0_292 (AdoptOpenJDK 25.292-b10)
OS: Mac OS X 10.16 x86_64
$ java -version
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
Best regards,
Alessandro
On Sat, 23 Jul 2022 at 05:08, Andrei Sereda <as...@gmail.com> wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.31.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=c416e109460d8e439078206a48057b504b6bb08b
>
> Its hash is c416e109460d8e439078206a48057b504b6bb08b
>
> Tag:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.31.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.31.0-rc0
> (revision 55918)
>
> The hashes of the artifacts are as follows:
>
> 527e699857958b9d98e733059bd67ca6fc42e75238074dec65cc86caa8f5ae176e269d9ac478754ad206ea2336289a8f40f37ee86818130b37b53a53ee79bb2c
> *apache-calcite-1.31.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1166/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/sereda.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build"
> (requires an appropriate Gradle/JDK installation)
>
> Please vote on releasing this package as Apache Calcite 1.31.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.31.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (non-binding)
>