You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/25 03:15:31 UTC

[GitHub] [pulsar] Shoothzj commented on pull request #11761: Forget to update memory usage on message send timeout

Shoothzj commented on pull request #11761:
URL: https://github.com/apache/pulsar/pull/11761#issuecomment-905148299


   > Change LGTM. It should be easy to assert the the memory size in a unit test.
   > 
   > 1. Create producer
   > 2. Stop broker
   > 3. Publish with timeout
   > 4. Wait until all send operations have failed
   > 5. The memory controller should report usage==0
   
   You are right. Unit test is more efficient way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org