You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/08 05:48:52 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

yamt opened a new pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995


   ## Summary
   For some use cases, XTENSA_IMEM_MAXIMIZE_HEAP_REGION does not
   provide enough memory for imem heap.
   
   This commit allows to use the entire region2 heap for imem.
   
   ## Impact
   
   ## Testing
   a slight variation was tested with my local app.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-800027056


   @yamt any plans for this one, or should we close it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-792570045


   @yamt I have a commit that moves the internal memory to region 2 because as you mentioned region 1 could in some cases not have enough space (lots of static allocation for instance).  I also have a few more KB of memory added to the heap from the unused parts of the ROM bootloader.  I'm doing more tests as I'm seeing issues with QEMU and SMP (rest all ok, SMP in hardware included).  Would you mind if we get that one instead?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-792599905


   Thanks @yamt 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-800028720


   @Ouss4 actually i forgot this one. :-)
   thank you for reminding.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt closed pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
yamt closed pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #2995: esp32: Add an option to use the whole region2 memory for imem heap

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2995:
URL: https://github.com/apache/incubator-nuttx/pull/2995#issuecomment-792594698


   > @yamt I have a commit that moves the internal memory to region 2 because as you mentioned region 1 could in some cases not have enough space (lots of static allocation for instance). I also have a few more KB of memory added to the heap from the unused parts of the ROM bootloader. I'm doing more tests as I'm seeing issues with QEMU and SMP (rest all ok, SMP in hardware included). Would you mind if we get that one instead?
   
   sure. frankly speaking i feel this PR a bit hacky. i'll make this a draft for now as i want to look at your version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org