You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "renoth (via GitHub)" <gi...@apache.org> on 2024/07/31 06:26:59 UTC
[PR] Make AutoCompleteTextField more Accessible [wicket]
renoth opened a new pull request, #933:
URL: https://github.com/apache/wicket/pull/933
Autocomplete textfields arent read properly by a screenreader when selection the options with arrow keys. This PR adresses that issue.
**input must have**
role="combobox"
aria-expanded="true/false"
autocomplete="off"
aria-autocomplete="list"
aria-controls=$ID
**ul must have**
role="listbox"
id=$ID
**li must have**
role="option"
aria-posinset: Item Position
aria-setsize: length of List
aria-selected: true when selected / false when not
tabindex="-1"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7120] - Make AutoCompleteTextField more Accessible [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #933:
URL: https://github.com/apache/wicket/pull/933#issuecomment-2296411947
Thank you, @renoth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make AutoCompleteTextField more Accessible [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #933:
URL: https://github.com/apache/wicket/pull/933#issuecomment-2259768876
Tested with NVDA 2024.2 and Firefox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7120] - Make AutoCompleteTextField more Accessible [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #933:
URL: https://github.com/apache/wicket/pull/933#issuecomment-2264923458
I created https://issues.apache.org/jira/browse/WICKET-7120 and hopefully fixed the compiler errors in js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7120] - Make AutoCompleteTextField more Accessible [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #933:
URL: https://github.com/apache/wicket/pull/933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make AutoCompleteTextField more Accessible [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #933:
URL: https://github.com/apache/wicket/pull/933#issuecomment-2264904671
```
SEVERE: /home/runner/work/wicket/wicket/wicket-extensions/target/classes/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js:401:3: ERROR - [JSC_LANGUAGE_FEATURE] This language feature is only supported for ECMASCRIPT_2015 mode or better: let declaration.
401| let input = Wicket.$(ajaxAttributes.c);
^
```
It seems the minifier needs some setting on to alloq arrow functions ...
We also need a Jira ticket for the changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make AutoCompleteTextField more Accessible [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on code in PR #933:
URL: https://github.com/apache/wicket/pull/933#discussion_r1701526673
##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js:
##########
@@ -484,10 +500,10 @@
function getWindowScrollXY() {
var scrOfX = 0, scrOfY = 0;
- if( typeof( window.pageYOffset ) === 'number' ) {
+ if( typeof( window.scrollY ) === 'number' ) {
//Netscape compliant
- scrOfY = window.pageYOffset;
- scrOfX = window.pageXOffset;
+ scrOfY = window.scrollY;
Review Comment:
No, it was suggested by the IDE because pageXOffset is deprecated
https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L25491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make AutoCompleteTextField more Accessible [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #933:
URL: https://github.com/apache/wicket/pull/933#discussion_r1701523310
##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js:
##########
@@ -484,10 +500,10 @@
function getWindowScrollXY() {
var scrOfX = 0, scrOfY = 0;
- if( typeof( window.pageYOffset ) === 'number' ) {
+ if( typeof( window.scrollY ) === 'number' ) {
//Netscape compliant
- scrOfY = window.pageYOffset;
- scrOfX = window.pageXOffset;
+ scrOfY = window.scrollY;
Review Comment:
Did you face problems with `pageXOffset` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org