You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/10/20 14:53:37 UTC
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25157
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
Values of VARCHAR(N) columns longer than N bytes were not truncated
when reading DELTA_LENGTH_BYTE_ARRAY encoded Parquet pages, unlike
PLAIN and dictionary encoded pages. This could hit a DCHECK in debug
builds.
Testing:
- added a decoder unit test
- extended the Trino Parquet interop test to all scalar types,
including a VARCHAR column shortened with ALTER TABLE
Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder-test.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder.h
A testdata/workloads/functional-query/queries/QueryTest/trino-interop-parquet.test
M tests/custom_cluster/test_trino_interop.py
6 files changed, 104 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/25157/1
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14303/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Oct 2026 15:56:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
Values of VARCHAR(N) columns longer than N bytes were not truncated
when reading DELTA_LENGTH_BYTE_ARRAY encoded Parquet pages, unlike
PLAIN and dictionary encoded pages. This could hit a DCHECK in debug
builds.
Testing:
- added a decoder unit test
- extended the Trino Parquet interop test to all scalar types,
including a VARCHAR column shortened with ALTER TABLE
Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Assisted-by: Claude Opus 5.5 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/25157
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder-test.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc
M be/src/exec/parquet/parquet-delta-length-byte-array-decoder.h
A testdata/workloads/functional-query/queries/QueryTest/trino-interop-parquet.test
M tests/custom_cluster/test_trino_interop.py
6 files changed, 104 insertions(+), 26 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
Patch Set 1: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Oct 2026 15:53:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Oct 2026 15:56:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24610/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Oct 2026 15:17:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15598: Truncate VARCHAR values in DELTA LENGTH BYTE ARRAY pages
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25157 )
Change subject: IMPALA-15598: Truncate VARCHAR values in DELTA_LENGTH_BYTE_ARRAY pages
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/25157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98422541f3f2e03363dd41e48a5da22de1b0a9e7
Gerrit-Change-Number: 25157
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Oct 2026 20:25:48 +0000
Gerrit-HasComments: No