You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Pavlin Radoslavov (JIRA)" <ji...@apache.org> on 2011/01/11 09:19:45 UTC
[jira] Created: (THRIFT-1036) Auto-generated C++ code fails to
compile with "-Werror -Wextra -Wall" g++ compiler flags
Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++ compiler flags
----------------------------------------------------------------------------------------
Key: THRIFT-1036
URL: https://issues.apache.org/jira/browse/THRIFT-1036
Project: Thrift
Issue Type: Bug
Components: C++ - Compiler
Affects Versions: 0.7
Environment: OS: FreeBSD-8.0
Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]
Reporter: Pavlin Radoslavov
Fix For: 0.7
If the following command is used to auto-generate the C++ code
thrift --gen cpp:cob_style foo.thrift
then some of the auto-generated code contains the following:
class FooCobClient : virtual public FooCobClIf {
...
virtual void completed__(bool success) {}
...
};
The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
gen-cpp/Foo.h:767: warning: unused parameter 'success'
The solution is trivial: just comment-out the unused "success" argument (see attached patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1036) Auto-generated C++ code fails to
compile with "-Werror -Wextra -Wall" g++ compiler flags
Posted by "Pavlin Radoslavov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavlin Radoslavov updated THRIFT-1036:
--------------------------------------
Attachment: thrift-jira-1036.patch
A trivial patch to fix the compilation issue.
> Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++ compiler flags
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-1036
> URL: https://issues.apache.org/jira/browse/THRIFT-1036
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.7
> Environment: OS: FreeBSD-8.0
> Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]
> Reporter: Pavlin Radoslavov
> Fix For: 0.7
>
> Attachments: thrift-jira-1036.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> If the following command is used to auto-generate the C++ code
> thrift --gen cpp:cob_style foo.thrift
> then some of the auto-generated code contains the following:
>
> class FooCobClient : virtual public FooCobClIf {
> ...
> virtual void completed__(bool success) {}
> ...
> };
> The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
> gen-cpp/Foo.h:767: warning: unused parameter 'success'
> The solution is trivial: just comment-out the unused "success" argument (see attached patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1036) Auto-generated C++ code fails to
compile with "-Werror -Wextra -Wall" g++ compiler flags
Posted by "Pavlin Radoslavov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavlin Radoslavov updated THRIFT-1036:
--------------------------------------
Description:
If the following command is used to auto-generate the C++ code
thrift --gen cpp:cob_style foo.thrift
then some of the auto-generated code contains the following:
class FooCobClient : virtual public FooCobClIf {
...
virtual void completed__(bool success) {}
...
};
The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
gen-cpp/Foo.h:767: warning: unused parameter 'success'
The solution is trivial: just comment-out the unused "success" argument when the code is
auto-generated (see attached patch).
was:
If the following command is used to auto-generate the C++ code
thrift --gen cpp:cob_style foo.thrift
then some of the auto-generated code contains the following:
class FooCobClient : virtual public FooCobClIf {
...
virtual void completed__(bool success) {}
...
};
The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
gen-cpp/Foo.h:767: warning: unused parameter 'success'
The solution is trivial: just comment-out the unused "success" argument (see attached patch).
> Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++ compiler flags
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-1036
> URL: https://issues.apache.org/jira/browse/THRIFT-1036
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.7
> Environment: OS: FreeBSD-8.0
> Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]
> Reporter: Pavlin Radoslavov
> Fix For: 0.7
>
> Attachments: thrift-jira-1036.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> If the following command is used to auto-generate the C++ code
> thrift --gen cpp:cob_style foo.thrift
> then some of the auto-generated code contains the following:
>
> class FooCobClient : virtual public FooCobClIf {
> ...
> virtual void completed__(bool success) {}
> ...
> };
> The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
> gen-cpp/Foo.h:767: warning: unused parameter 'success'
> The solution is trivial: just comment-out the unused "success" argument when the code is
> auto-generated (see attached patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-1036) Auto-generated C++ code fails to
compile with "-Werror -Wextra -Wall" g++ compiler flags
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1036.
---------------------------------
Resolution: Fixed
Assignee: Roger Meier
committed
> Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++ compiler flags
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-1036
> URL: https://issues.apache.org/jira/browse/THRIFT-1036
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.7
> Environment: OS: FreeBSD-8.0
> Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]
> Reporter: Pavlin Radoslavov
> Assignee: Roger Meier
> Fix For: 0.7
>
> Attachments: thrift-jira-1036.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> If the following command is used to auto-generate the C++ code
> thrift --gen cpp:cob_style foo.thrift
> then some of the auto-generated code contains the following:
>
> class FooCobClient : virtual public FooCobClIf {
> ...
> virtual void completed__(bool success) {}
> ...
> };
> The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
> gen-cpp/Foo.h:767: warning: unused parameter 'success'
> The solution is trivial: just comment-out the unused "success" argument when the code is
> auto-generated (see attached patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.