You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/08 03:14:29 UTC
Review Request: Added the ability to install a failure signal handler,
updated the master and slave mains to do so.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10990/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This is to catch mysterious SIGPIPE deaths in the slave / master.
Diffs
-----
src/logging/logging.hpp 6cf93e94ba0838a914ba3813b823f7161732695f
src/logging/logging.cpp 32b2ac74417b3c31c8f51643ce78bddd7e321e36
src/master/main.cpp d6e1c730910bd5d31472c624b1e559d3bc827262
src/slave/main.cpp 80b2a3c7aae15782f03030f354a87ecbfa7da155
Diff: https://reviews.apache.org/r/10990/diff/
Testing
-------
Tested by inducing a SIGPIPE in the Slave:
Received signal 'Broken pipe', escalating to SIGABRT
*** Aborted at 1367973270 (unix time) try "date -d @1367973270" if you are using GNU date ***
PC: @ 0x7f8c089739dd raise
*** SIGABRT (@0xf21) received by PID 3873 (TID 0x4bf76940) from PID 3873; stack trace: ***
@ 0x7f8c08973b10 (unknown)
@ 0x7f8c089739dd raise
@ 0x7f8c08973b10 (unknown)
@ 0x7f8c0897289b __libc_write
@ 0x7f8c08fa465c mesos::internal::slave::Slave::_initialize()
@ 0x7f8c08fa6d93 std::tr1::_Function_handler<>::_M_invoke()
@ 0x7f8c08fb0834 std::tr1::_Function_handler<>::_M_invoke()
@ 0x7f8c091a5a6a process::ProcessManager::resume()
@ 0x7f8c091a638f process::schedule()
@ 0x7f8c0896b73d start_thread
@ 0x7f8c0734ff6d clone
./bin/mesos-slave.sh: line 24: 3873 Aborted /home/bmahler/git/mesos/build/src/mesos-slave "${@}"
Thanks,
Ben Mahler
Re: Review Request: Added the ability to install a failure signal handler,
updated the master and slave mains to do so.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10990/#review20288
-----------------------------------------------------------
Ship it!
src/logging/logging.cpp
<https://reviews.apache.org/r/10990/#comment41816>
Add SIGSEGV?
- Vinod Kone
On May 8, 2013, 1:14 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10990/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 1:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is to catch mysterious SIGPIPE deaths in the slave / master.
>
>
> Diffs
> -----
>
> src/logging/logging.hpp 6cf93e94ba0838a914ba3813b823f7161732695f
> src/logging/logging.cpp 32b2ac74417b3c31c8f51643ce78bddd7e321e36
> src/master/main.cpp d6e1c730910bd5d31472c624b1e559d3bc827262
> src/slave/main.cpp 80b2a3c7aae15782f03030f354a87ecbfa7da155
>
> Diff: https://reviews.apache.org/r/10990/diff/
>
>
> Testing
> -------
>
> Tested by inducing a SIGPIPE in the Slave:
>
> Received signal 'Broken pipe', escalating to SIGABRT
> *** Aborted at 1367973270 (unix time) try "date -d @1367973270" if you are using GNU date ***
> PC: @ 0x7f8c089739dd raise
> *** SIGABRT (@0xf21) received by PID 3873 (TID 0x4bf76940) from PID 3873; stack trace: ***
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c089739dd raise
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c0897289b __libc_write
> @ 0x7f8c08fa465c mesos::internal::slave::Slave::_initialize()
> @ 0x7f8c08fa6d93 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c08fb0834 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c091a5a6a process::ProcessManager::resume()
> @ 0x7f8c091a638f process::schedule()
> @ 0x7f8c0896b73d start_thread
> @ 0x7f8c0734ff6d clone
> ./bin/mesos-slave.sh: line 24: 3873 Aborted /home/bmahler/git/mesos/build/src/mesos-slave "${@}"
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added the ability to install a failure signal handler,
updated the master and slave mains to do so.
Posted by Ben Mahler <be...@gmail.com>.
> On May 8, 2013, 1:55 a.m., Benjamin Hindman wrote:
> >
Sorry for not waiting on your review, will commit the updates.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10990/#review20287
-----------------------------------------------------------
On May 8, 2013, 1:50 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10990/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 1:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is to catch mysterious SIGPIPE deaths in the slave / master.
>
>
> Diffs
> -----
>
> src/logging/logging.hpp 6cf93e94ba0838a914ba3813b823f7161732695f
> src/logging/logging.cpp 32b2ac74417b3c31c8f51643ce78bddd7e321e36
> src/master/main.cpp d6e1c730910bd5d31472c624b1e559d3bc827262
> src/slave/main.cpp 80b2a3c7aae15782f03030f354a87ecbfa7da155
>
> Diff: https://reviews.apache.org/r/10990/diff/
>
>
> Testing
> -------
>
> Tested by inducing a SIGPIPE in the Slave:
>
> Received signal 'Broken pipe', escalating to SIGABRT
> *** Aborted at 1367973270 (unix time) try "date -d @1367973270" if you are using GNU date ***
> PC: @ 0x7f8c089739dd raise
> *** SIGABRT (@0xf21) received by PID 3873 (TID 0x4bf76940) from PID 3873; stack trace: ***
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c089739dd raise
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c0897289b __libc_write
> @ 0x7f8c08fa465c mesos::internal::slave::Slave::_initialize()
> @ 0x7f8c08fa6d93 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c08fb0834 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c091a5a6a process::ProcessManager::resume()
> @ 0x7f8c091a638f process::schedule()
> @ 0x7f8c0896b73d start_thread
> @ 0x7f8c0734ff6d clone
> ./bin/mesos-slave.sh: line 24: 3873 Aborted /home/bmahler/git/mesos/build/src/mesos-slave "${@}"
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added the ability to install a failure signal handler,
updated the master and slave mains to do so.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10990/#review20287
-----------------------------------------------------------
src/logging/logging.cpp
<https://reviews.apache.org/r/10990/#comment41815>
Any reason not to do LOG(WARNING)?
src/logging/logging.cpp
<https://reviews.apache.org/r/10990/#comment41817>
Comment doesn't seem to reflect the code.
- Benjamin Hindman
On May 8, 2013, 1:50 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10990/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 1:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is to catch mysterious SIGPIPE deaths in the slave / master.
>
>
> Diffs
> -----
>
> src/logging/logging.hpp 6cf93e94ba0838a914ba3813b823f7161732695f
> src/logging/logging.cpp 32b2ac74417b3c31c8f51643ce78bddd7e321e36
> src/master/main.cpp d6e1c730910bd5d31472c624b1e559d3bc827262
> src/slave/main.cpp 80b2a3c7aae15782f03030f354a87ecbfa7da155
>
> Diff: https://reviews.apache.org/r/10990/diff/
>
>
> Testing
> -------
>
> Tested by inducing a SIGPIPE in the Slave:
>
> Received signal 'Broken pipe', escalating to SIGABRT
> *** Aborted at 1367973270 (unix time) try "date -d @1367973270" if you are using GNU date ***
> PC: @ 0x7f8c089739dd raise
> *** SIGABRT (@0xf21) received by PID 3873 (TID 0x4bf76940) from PID 3873; stack trace: ***
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c089739dd raise
> @ 0x7f8c08973b10 (unknown)
> @ 0x7f8c0897289b __libc_write
> @ 0x7f8c08fa465c mesos::internal::slave::Slave::_initialize()
> @ 0x7f8c08fa6d93 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c08fb0834 std::tr1::_Function_handler<>::_M_invoke()
> @ 0x7f8c091a5a6a process::ProcessManager::resume()
> @ 0x7f8c091a638f process::schedule()
> @ 0x7f8c0896b73d start_thread
> @ 0x7f8c0734ff6d clone
> ./bin/mesos-slave.sh: line 24: 3873 Aborted /home/bmahler/git/mesos/build/src/mesos-slave "${@}"
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added the ability to install a failure signal handler,
updated the master and slave mains to do so.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10990/
-----------------------------------------------------------
(Updated May 8, 2013, 1:50 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's comment.
Description
-------
This is to catch mysterious SIGPIPE deaths in the slave / master.
Diffs (updated)
-----
src/logging/logging.hpp 6cf93e94ba0838a914ba3813b823f7161732695f
src/logging/logging.cpp 32b2ac74417b3c31c8f51643ce78bddd7e321e36
src/master/main.cpp d6e1c730910bd5d31472c624b1e559d3bc827262
src/slave/main.cpp 80b2a3c7aae15782f03030f354a87ecbfa7da155
Diff: https://reviews.apache.org/r/10990/diff/
Testing
-------
Tested by inducing a SIGPIPE in the Slave:
Received signal 'Broken pipe', escalating to SIGABRT
*** Aborted at 1367973270 (unix time) try "date -d @1367973270" if you are using GNU date ***
PC: @ 0x7f8c089739dd raise
*** SIGABRT (@0xf21) received by PID 3873 (TID 0x4bf76940) from PID 3873; stack trace: ***
@ 0x7f8c08973b10 (unknown)
@ 0x7f8c089739dd raise
@ 0x7f8c08973b10 (unknown)
@ 0x7f8c0897289b __libc_write
@ 0x7f8c08fa465c mesos::internal::slave::Slave::_initialize()
@ 0x7f8c08fa6d93 std::tr1::_Function_handler<>::_M_invoke()
@ 0x7f8c08fb0834 std::tr1::_Function_handler<>::_M_invoke()
@ 0x7f8c091a5a6a process::ProcessManager::resume()
@ 0x7f8c091a638f process::schedule()
@ 0x7f8c0896b73d start_thread
@ 0x7f8c0734ff6d clone
./bin/mesos-slave.sh: line 24: 3873 Aborted /home/bmahler/git/mesos/build/src/mesos-slave "${@}"
Thanks,
Ben Mahler