[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #1233: LUCENE-9202: refactor leaf collectors in TopFieldCollector
URL: https://github.com/apache/lucene-solr/pull/1233#discussion_r374761494
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
 ##########
 @@ -555,7 +519,7 @@ public static void populateScores(ScoreDoc[] topDocs, IndexSearcher searcher, Qu
 
   final void add(int slot, int doc) {
     bottom = pq.add(new Entry(slot, docBase + doc));
-    queueFull = totalHits == numHits;
+    queueFull = slot == numHits - 1;
 
 Review comment:
   Hmm why was this needed?  Did we lose (easy) access to `totalHits`?
   
   Can we `assert slot < numHits`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org