You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/12/01 21:48:57 UTC
Review Request 64261: Update LDAP Authentication process to work with
improved user management facility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
Bugs: AMBARI-21219
https://issues.apache.org/jira/browse/AMBARI-21219
Repository: ambari
Description
-------
Update LDAP Authentication process to work with improved user management facility
Diffs
-----
ambari-server/docs/configuration/index.md 514e9edcc3
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 8904199cfd
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java f1e1881cea
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 0e28e50709
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java 0e5c913baa
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java bf30b83dd1
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java a6f4387398
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java a4a95165e1
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ebe26a237d
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java fdc4a2f1c3
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java 64ec2019f6
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java d465c019f7
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java 1aafaa1889
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java cad734c682
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java e99bdfd5c6
Diff: https://reviews.apache.org/r/64261/diff/1/
Testing
-------
Manually tested against OpenLDAP and Active Directory
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:23 min
[INFO] Finished at: 2017-12-01T16:35:50-05:00
[INFO] Final Memory: 99M/2005M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 64261: Update LDAP Authentication process to work
with improved user management facility
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/#review192707
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 701-702 (original), 701-702 (patched)
<https://reviews.apache.org/r/64261/#comment270959>
This property seems important enough to add @Markdown
- Nate Cole
On Dec. 1, 2017, 4:53 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64261/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 4:53 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
>
>
> Bugs: AMBARI-21219
> https://issues.apache.org/jira/browse/AMBARI-21219
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update LDAP Authentication process to work with improved user management facility
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 514e9edcc3
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 8904199cfd
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java f1e1881cea
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 0e28e50709
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java 0e5c913baa
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java bf30b83dd1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java a6f4387398
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java a4a95165e1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ebe26a237d
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java fdc4a2f1c3
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java 64ec2019f6
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java d465c019f7
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java 1aafaa1889
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java cad734c682
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java e99bdfd5c6
>
>
> Diff: https://reviews.apache.org/r/64261/diff/2/
>
>
> Testing
> -------
>
> Manually tested against OpenLDAP and Active Directory
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:23 min
> [INFO] Finished at: 2017-12-01T16:35:50-05:00
> [INFO] Final Memory: 99M/2005M
> [INFO] ------------------------------------------------------------------------
> ```
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 64261: Update LDAP Authentication process to work
with improved user management facility
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/#review192981
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Dec. 1, 2017, 9:53 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64261/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 9:53 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
>
>
> Bugs: AMBARI-21219
> https://issues.apache.org/jira/browse/AMBARI-21219
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update LDAP Authentication process to work with improved user management facility
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 514e9edcc3
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 8904199cfd
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java f1e1881cea
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 0e28e50709
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java 0e5c913baa
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java bf30b83dd1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java a6f4387398
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java a4a95165e1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ebe26a237d
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java fdc4a2f1c3
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java 64ec2019f6
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java d465c019f7
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java 1aafaa1889
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java cad734c682
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java e99bdfd5c6
>
>
> Diff: https://reviews.apache.org/r/64261/diff/2/
>
>
> Testing
> -------
>
> Manually tested against OpenLDAP and Active Directory
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:23 min
> [INFO] Finished at: 2017-12-01T16:35:50-05:00
> [INFO] Final Memory: 99M/2005M
> [INFO] ------------------------------------------------------------------------
> ```
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 64261: Update LDAP Authentication process to work
with improved user management facility
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/#review192984
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 1, 2017, 4:53 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64261/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 4:53 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
>
>
> Bugs: AMBARI-21219
> https://issues.apache.org/jira/browse/AMBARI-21219
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update LDAP Authentication process to work with improved user management facility
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 514e9edcc3
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 8904199cfd
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java f1e1881cea
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 0e28e50709
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java 0e5c913baa
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java bf30b83dd1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java a6f4387398
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java a4a95165e1
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ebe26a237d
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java fdc4a2f1c3
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java 64ec2019f6
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java d465c019f7
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java 1aafaa1889
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java cad734c682
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java e99bdfd5c6
>
>
> Diff: https://reviews.apache.org/r/64261/diff/2/
>
>
> Testing
> -------
>
> Manually tested against OpenLDAP and Active Directory
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:23 min
> [INFO] Finished at: 2017-12-01T16:35:50-05:00
> [INFO] Final Memory: 99M/2005M
> [INFO] ------------------------------------------------------------------------
> ```
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 64261: Update LDAP Authentication process to work
with improved user management facility
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 4:53 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
Changes
-------
Regenerated index.md.
Bugs: AMBARI-21219
https://issues.apache.org/jira/browse/AMBARI-21219
Repository: ambari
Description
-------
Update LDAP Authentication process to work with improved user management facility
Diffs (updated)
-----
ambari-server/docs/configuration/index.md 514e9edcc3
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 8904199cfd
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java f1e1881cea
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 0e28e50709
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java 0e5c913baa
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java bf30b83dd1
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java a6f4387398
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java a4a95165e1
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ebe26a237d
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java fdc4a2f1c3
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java 64ec2019f6
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java d465c019f7
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java 1aafaa1889
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java cad734c682
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java e99bdfd5c6
Diff: https://reviews.apache.org/r/64261/diff/2/
Changes: https://reviews.apache.org/r/64261/diff/1-2/
Testing
-------
Manually tested against OpenLDAP and Active Directory
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:23 min
[INFO] Finished at: 2017-12-01T16:35:50-05:00
[INFO] Final Memory: 99M/2005M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results: PENDING
Thanks,
Robert Levas