You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ma...@apache.org on 2010/02/11 04:10:01 UTC
svn commit: r908815 -
/lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java
Author: markrmiller
Date: Thu Feb 11 03:10:00 2010
New Revision: 908815
URL: http://svn.apache.org/viewvc?rev=908815&view=rev
Log:
remove nocommits
Modified:
lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java
Modified: lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java?rev=908815&r1=908814&r2=908815&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java (original)
+++ lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/DefaultConnectionStrategy.java Thu Feb 11 03:10:00 2010
@@ -28,7 +28,7 @@
import org.slf4j.LoggerFactory;
/**
- * nocommit : default needs backoff retry reconnection attempts
+ * TODO: improve backoff retry impl
*/
public class DefaultConnectionStrategy extends ZkClientConnectionStrategy {
@@ -52,20 +52,17 @@
boolean connected = false;
try {
updater.update(new SolrZooKeeper(serverAddress, zkClientTimeout, watcher));
- // nocommit
log.info("Reconnected to ZooKeeper");
connected = true;
} catch (Exception e) {
- // nocommit
- e.printStackTrace();
+ log.error("", e);
log.info("Reconnect to ZooKeeper failed");
}
if(connected) {
executor.shutdownNow();
} else {
- // nocommit
if(delay < 240000) {
- delay = delay * 2; // nocommit : back off retry that levels off
+ delay = delay * 2;
}
executor.schedule(this, delay, TimeUnit.MILLISECONDS);
}