[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)

[GitBox <gi...@apache.org>]

btashton edited a comment on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723657228


   Ok here is the issue.  While you are correct that the `make distclean` does clean these files up, they are not in the gitignore which is required.  You can see the build check here that is run in `cibuild.sh`.  So after you run a build, run `git status` in both the  os and app directory and make sure it comes out clean.
   
   ```
   function build {
     echo "  Building NuttX..."
     makefunc
     if [ ${SAVEARTIFACTS} -eq 1 ]; then
       artifactconfigdir=$ARTIFACTDIR/$(echo $config | sed "s/:/\//")/
       mkdir -p $artifactconfigdir
       xargs -I "{}" cp "{}" $artifactconfigdir < $nuttx/nuttx.manifest
     fi
   
     # Ensure defconfig in the canonical form
   
     if ! ./tools/refresh.sh --silent $config; then
       fail=1
     fi
   
     # Ensure nuttx and apps directory in clean state
   
     if [ -d $nuttx/.git ] || [ -d $APPSDIR/.git ]; then
       if [[ -n $(git -C $nuttx status -s) ]]; then
         git -C $nuttx status
         fail=1
       fi
       if [[ -n $(git -C $APPSDIR status -s) ]]; then
         git -C $APPSDIR status
         fail=1
       fi
     fi
   
     return $fail
   }
   ```
   
   This fix will be in the apps repo, so we will need to make that change there and merge it then we can rebase and kick this build again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org