You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:40:01 UTC

[GitHub] [ozone] umamaheswararao commented on pull request #2055: HDDS-4954. Add replicaIndex to the RPC protocols

umamaheswararao commented on pull request #2055:
URL: https://github.com/apache/ozone/pull/2055#issuecomment-803000723


   Thanks for separating the replication type changes into separate JIRA.
   Please add the replication index to org.apache.hadoop.hdds.client.BlockID and org.apache.hadoop.hdds.client.ContainerBlockID
   This will be needed when we create container from client, we anyway pass blockID to DN. If index available there, then DN know which index. 
   Current patch seems t be covering the protocols only from SCM and DN. The above change can help to cover client needed changes.
   
   We also discussed yesterday that, let's not make index as the property to chunkInfo. I am more comfortable if we make that as property to ContainerBlockID instead. Thanks for removing them in latest patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org