You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2010/10/14 01:25:47 UTC

svn commit: r1022323 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

Author: kkolinko
Date: Wed Oct 13 23:25:47 2010
New Revision: 1022323

URL: http://svn.apache.org/viewvc?rev=1022323&view=rev
Log:
Followup to r1022303
I think that releasing the socket should be done before passing it away to a poller.

Modified:
    tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=1022323&r1=1022322&r2=1022323&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Wed Oct 13 23:25:47 2010
@@ -395,8 +395,8 @@ public class Http11NioProtocol extends A
                 } else if (state == SocketState.OPEN){
                     // In keep-alive but between requests. OK to recycle
                     // processor. Continue to poll for the next request.
-                    socket.getPoller().add(socket);
                     release(socket);
+                    socket.getPoller().add(socket);
                 } else {
                     // Connection closed. OK to recycle the processor.
                     release(socket);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: svn commit: r1022323 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

Posted by Mark Thomas <ma...@apache.org>.
On 14/10/2010 00:25, kkolinko@apache.org wrote:
> Author: kkolinko
> Date: Wed Oct 13 23:25:47 2010
> New Revision: 1022323
> 
> URL: http://svn.apache.org/viewvc?rev=1022323&view=rev
> Log:
> Followup to r1022303
> I think that releasing the socket should be done before passing it away to a poller.

Thanks for picking that up.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org