You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/12 21:10:41 UTC
[I] Remove the nltk GHSA-8mgp-746c-j5xp dependency-review allowlist entry once nltk ships a fix [airflow]
potiuk opened a new issue, #73049:
URL: https://github.com/apache/airflow/issues/73049
### What the workaround is
`.github/workflows/java-sdk-dependency-security.yml` now passes `allow-ghsas: GHSA-8mgp-746c-j5xp`
to `actions/dependency-review-action`, suppressing that one advisory.
### Why
[GHSA-8mgp-746c-j5xp](https://github.com/advisories/GHSA-8mgp-746c-j5xp) / CVE-2026-81726 (high,
CVSS 7.0) is a path-traversal in nltk's model-artifact APIs. **Every published nltk version is
affected** — the advisory range is `<= 3.10.3` and 3.10.3 is the newest release on PyPI, with no
patched version recorded. Upstream has fixes on `main` (nltk/nltk#3757, nltk/nltk#3759,
nltk/nltk#3813) but has not cut a release carrying them, so there is nothing to upgrade to.
nltk is not a dependency of Airflow. It arrives transitively through `llama-index-core`, which is
an optional `llamaindex` extra and a dev dependency of `providers/common/ai`. None of the affected
APIs (`TransitionParser.train` / `.parse`, `AveragedPerceptron.save` / `.load`,
`PerceptronTagger.save_to_json`, `save_maxent_params`) is reachable from Airflow code.
The job fires on any PR touching `java-sdk/**`, but `dependency-review-action` reviews the whole
repository dependency graph, so it also sees `uv.lock`. That is how a Python transitive dependency
ends up blocking the Java SDK check — most visibly on the 3.3.2rc1 sync PR (#72946), where
`uv.lock` moves nltk 3.10.0 → 3.10.3 and both versions are inside the advisory range.
### Follow-up work
- Watch for an nltk release above 3.10.3 that carries the fix.
- Bump nltk in `uv.lock` (it will come along with the next `llama-index-core` resolution) and drop
the `allow-ghsas` line plus the comment above it.
- Consider separately whether `java-sdk-dependency-security.yml` should review only the Java SDK's
dependency graph rather than the whole repository's — a Python lockfile change failing the Java
SDK gate is surprising, but the action has no path scoping today.
### Acceptance criteria
The `allow-ghsas` entry and its explanatory comment are removed from
`.github/workflows/java-sdk-dependency-security.yml`, and the "Reject vulnerable dependency changes"
job passes on a PR that touches both `java-sdk/**` and `uv.lock`.
---
Drafted-by: Claude Opus 5 (1M context) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the nltk GHSA-8mgp-746c-j5xp dependency-review allowlist entry once nltk ships a fix [airflow]
Posted by "namanjain24-sudo (via GitHub)" <gi...@apache.org>.
namanjain24-sudo commented on issue #73049:
URL: https://github.com/apache/airflow/issues/73049#issuecomment-5652600756
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the nltk GHSA-8mgp-746c-j5xp dependency-review allowlist entry once nltk ships a fix [airflow]
Posted by "namanjain24-sudo (via GitHub)" <gi...@apache.org>.
namanjain24-sudo commented on issue #73049:
URL: https://github.com/apache/airflow/issues/73049#issuecomment-5652835802
Small update while this waits on nltk:
- On main the entry now lives in `.github/workflows/dependency-review.yml` (the comment + `allow-ghsas` line, L74-82), added in #73061. `java-sdk-dependency-security.yml` only runs on push/schedule now, so there's nothing left to remove there. The new gate triggers on `uv.lock` directly, so the `java-sdk/**` part of the acceptance criteria isn't needed anymore.
- nltk hasn't released yet. 3.10.3 is still the latest on PyPI and the 3.10.4 release PR (nltk/nltk#3826) is still a draft. On `develop`, none of the six functions listed in the advisory call a bare `open()` on the caller's path anymore, they all go through `nltk.pathsec` now. ekaf also said [here](https://github.com/nltk/nltk/pull/3753#issuecomment-5630323840) they could release once those six are fixed, so hopefully it's not far off.
Once 3.10.4 is out (and past the 4 day `exclude-newer` window), I'll bump nltk in `uv.lock` and remove the entry in the same PR. dependency-review only flags dependencies a PR adds, so removing the line on its own would pass even with 3.10.3 still locked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the nltk GHSA-8mgp-746c-j5xp dependency-review allowlist entry once nltk ships a fix [airflow]
Posted by "SYED-IRTEZA-HUSSAIN-RIZVI (via GitHub) via commits" <co...@airflow.apache.org>.
SYED-IRTEZA-HUSSAIN-RIZVI commented on issue #73049:
URL: https://github.com/apache/airflow/issues/73049#issuecomment-6865517766
Hi @potiuk , Can I work on this issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org