[GitHub] [cxf] reta commented on a diff in pull request #1454: CXF-8936 Fix h2 protocol negotiation in Jetty Transport

["reta (via GitHub)" <gi...@apache.org>]

reta commented on code in PR #1454:
URL: https://github.com/apache/cxf/pull/1454#discussion_r1342153331


##########
rt/transports/http-jetty/src/main/java/org/apache/cxf/transport/http_jetty/JettyHTTPServerEngine.java:
##########
@@ -697,7 +697,8 @@ AbstractConnector createConnectorJetty(SslContextFactory.Server sslcf, String ho
                         final SslConnectionFactory scf = new SslConnectionFactory(sslcf, alpn.getProtocol());
                         connectionFactories.add(scf);

Review Comment:
   Thanks for the fix, @huw0 , I believe the ALPN should go before HTTP/2, wdyt?
   
   ```
   connectionFactories.add(alpn);
   connectionFactories.add(new HTTP2ServerConnectionFactory(httpConfig));
   connectionFactories.add(scf);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org