You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/07/31 22:36:22 UTC

Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36998/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1409
    https://issues.apache.org/jira/browse/AURORA-1409


Repository: aurora


Description
-------

Use hostname instead of IP in Kerberos end to end test.


Diffs
-----

  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 02c9e6a4109376c62b93d75921686548d2d795f9 
  src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a 

Diff: https://reviews.apache.org/r/36998/diff/


Testing
-------

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kevin Sweeney


Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36998/#review93780
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On July 31, 2015, 8:36 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36998/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1409
>     https://issues.apache.org/jira/browse/AURORA-1409
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use hostname instead of IP in Kerberos end to end test.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 02c9e6a4109376c62b93d75921686548d2d795f9 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a 
> 
> Diff: https://reviews.apache.org/r/36998/diff/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36998/#review93779
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On July 31, 2015, 8:36 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36998/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1409
>     https://issues.apache.org/jira/browse/AURORA-1409
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use hostname instead of IP in Kerberos end to end test.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 02c9e6a4109376c62b93d75921686548d2d795f9 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a 
> 
> Diff: https://reviews.apache.org/r/36998/diff/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36998/#review93775
-----------------------------------------------------------

Ship it!


Master (d327773) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 31, 2015, 8:36 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36998/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1409
>     https://issues.apache.org/jira/browse/AURORA-1409
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use hostname instead of IP in Kerberos end to end test.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 02c9e6a4109376c62b93d75921686548d2d795f9 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a 
> 
> Diff: https://reviews.apache.org/r/36998/diff/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>