You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Noel Grandin <no...@gmail.com> on 2011/10/25 09:02:56 UTC
Re: svn commit: r1188387 - in /pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra:
TerraListViewSkin.java TerraTableViewSkin.java TerraTreeViewSkin.java
Hi
The coding convention is to use "consumed" and "!consumed".
Regards, Noel Grandin
smartini@apache.org wrote:
> Author: smartini
> Date: Mon Oct 24 21:17:01 2011
> New Revision: 1188387
>
> URL: http://svn.apache.org/viewvc?rev=1188387&view=rev
> Log:
> PIVOT-806
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java
>
> Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java?rev=1188387&r1=1188386&r2=1188387&view=diff
> ==============================================================================
> --- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java (original)
> +++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java Mon Oct 24 21:17:01 2011
> @@ -1079,7 +1079,8 @@ public class TerraListViewSkin extends C
> // Clear the highlight
> if (highlightIndex != -1
> && listView.getSelectMode() != ListView.SelectMode.NONE
> - && showHighlight) {
> + && showHighlight
> + && consumed == true) {
> repaintComponent(getItemBounds(highlightIndex));
> }
>
> @@ -1149,6 +1150,27 @@ public class TerraListViewSkin extends C
> }
> }
>
> +// TODO: add a style "wrapSelectNext" or similar to disable this behavior (now enabled by default) ...
> + if (true && consumed == false)
> + {
> + for (int i = 0, n = listData.getLength(); i < n; i++) {
> + if (!listView.isItemDisabled(i)) {
> + String string = itemRenderer.toString(listData.get(i));
> +
> + if (string != null
> + && string.length() > 0) {
> + char first = Character.toUpperCase(string.charAt(0));
> +
> + if (first == character) {
> + listView.setSelectedIndex(i);
> + consumed = true;
> + break;
> + }
> + }
> + }
> + }
> + }
> +
> return consumed;
> }
>
>
> Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java
> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java?rev=1188387&r1=1188386&r2=1188387&view=diff
> ==============================================================================
> --- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java (original)
> +++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java Mon Oct 24 21:17:01 2011
> @@ -1370,7 +1370,8 @@ public class TerraTableViewSkin extends
> // Clear the highlight
> if (highlightIndex != -1
> && tableView.getSelectMode() != TableView.SelectMode.NONE
> - && showHighlight) {
> + && showHighlight
> + && consumed == true) {
> repaintComponent(getRowBounds(highlightIndex));
> }
>
>
> Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java
> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java?rev=1188387&r1=1188386&r2=1188387&view=diff
> ==============================================================================
> --- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java (original)
> +++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Mon Oct 24 21:17:01 2011
> @@ -1897,7 +1897,9 @@ public class TerraTreeViewSkin extends C
> break;
> }
>
> - clearHighlightedNode();
> + if (consumed == true) {
> + clearHighlightedNode();
> + }
>
> return consumed;
> }
>
>