You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sk...@apache.org on 2008/06/19 20:56:47 UTC

svn commit: r669649 - /myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java

Author: skitching
Date: Thu Jun 19 11:56:47 2008
New Revision: 669649

URL: http://svn.apache.org/viewvc?rev=669649&view=rev
Log:
Re-enable UIViewRoot.setId and UIViewRoot.getId.

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java?rev=669649&r1=669648&r2=669649&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java Thu Jun 19 11:56:47 2008
@@ -330,21 +330,37 @@
     }
 
     /**
-     * Disable this property; although this class extends a base-class that
-     * defines a read/write id property, this particular subclass
-     * does not support setting it. Yes, this is broken OO design: direct
-     * all complaints to the JSF spec group.
+     * DO NOT USE.
+     * <p>
+
+     * Although this class extends a base-class that defines a read/write
+     * id property, it makes no sense for this particular subclass to support
+     * it. The tag library does not export this property for use, but there 
+     * is no way to "undeclare" a java method. Yes, this is broken OO design:
+     * direct all complaints to the JSF spec group.
+     * <p>
+     * This property should be disabled (ie throw an exception if invoked).
+     * However there are currently several places that call this method
+     * (eg during restoreState) so it just does the normal thing for the
+     * moment. TODO: fix callers then make this throw an exception.
      *
      * @JSFProperty tagExcluded="true"
      */
     public void setId(String id)
     {
-       throw new UnsupportedOperationException();
+        //  throw new UnsupportedOperationException();
+
+        // Re-enable for now. Things like the TreeStructureManager call this,
+        // even though they probably should not.
+        super.setId(id);
     }
 
     public String getId()
     {
-    	return null;
+    	// return null;
+
+        // Re-enable for now.
+        return super.getId();
     }
 
     /**