You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/12/28 02:06:58 UTC

Review Request 64857: Updated example frameworks for mesos-local.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-8357 and MESOS-8361
    https://issues.apache.org/jira/browse/MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-8361


Repository: mesos


Description
-------

Unifies handling of 'local' when supplied for the '--master' flag.


Diffs
-----

  src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
  src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
  src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/example_framework_flags.hpp PRE-CREATION 
  src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
  src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
  src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
  src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64857/diff/1/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/#review195015
-----------------------------------------------------------



PASS: Mesos patch 64857 was successfully built and tested.

Reviews applied: `['64846', '64847', '64848', '64849', '64857']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64857

- Mesos Reviewbot Windows


On Jan. 9, 2018, 3:19 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2018, 3:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8357 and MESOS-8361
>     https://issues.apache.org/jira/browse/MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unifies handling of 'local' when supplied for the '--master' flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64857/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/#review195409
-----------------------------------------------------------



PASS: Mesos patch 64857 was successfully built and tested.

Reviews applied: `['64846', '64847', '64848', '64849', '64857']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64857

- Mesos Reviewbot Windows


On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8357 and MESOS-8361
>     https://issues.apache.org/jira/browse/MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unifies handling of 'local' when supplied for the '--master' flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64857/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/#review195681
-----------------------------------------------------------



PASS: Mesos patch 64857 was successfully built and tested.

Reviews applied: `['64846', '64847', '64848', '64849', '64857']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64857

- Mesos Reviewbot Windows


On Jan. 17, 2018, 11:37 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 11:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8357 and MESOS-8361
>     https://issues.apache.org/jira/browse/MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unifies handling of 'local' when supplied for the '--master' flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64857/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 11:37 p.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Changes
-------

Limiting roles for all example frameworks when being started in "local"-master-mode.


Bugs: MESOS-8357 and MESOS-8361
    https://issues.apache.org/jira/browse/MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-8361


Repository: mesos


Description
-------

Unifies handling of 'local' when supplied for the '--master' flag.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
  src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
  src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
  src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
  src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
  src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64857/diff/4/

Changes: https://reviews.apache.org/r/64857/diff/3-4/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Till Toenshoff <to...@me.com>.

> On Jan. 16, 2018, 11:52 p.m., Vinod Kone wrote:
> > src/examples/dynamic_reservation_framework.cpp
> > Lines 389 (patched)
> > <https://reviews.apache.org/r/64857/diff/3/?file=1940023#file1940023line393>
> >
> >     don't you need to set roles in other example frameworks too for the local case?

Yes, for the sake of consistency, I should.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/#review195518
-----------------------------------------------------------


On Jan. 17, 2018, 11:37 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 11:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8357 and MESOS-8361
>     https://issues.apache.org/jira/browse/MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unifies handling of 'local' when supplied for the '--master' flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64857/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/#review195518
-----------------------------------------------------------




src/examples/dynamic_reservation_framework.cpp
Lines 389 (patched)
<https://reviews.apache.org/r/64857/#comment274709>

    don't you need to set roles in other example frameworks too for the local case?


- Vinod Kone


On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8357 and MESOS-8361
>     https://issues.apache.org/jira/browse/MESOS-8357
>     https://issues.apache.org/jira/browse/MESOS-8361
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unifies handling of 'local' when supplied for the '--master' flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
>   src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
>   src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
>   src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
>   src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
>   src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
>   src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
>   src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
>   src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 
> 
> 
> Diff: https://reviews.apache.org/r/64857/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/
-----------------------------------------------------------

(Updated Jan. 15, 2018, 12:29 a.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-8357 and MESOS-8361
    https://issues.apache.org/jira/browse/MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-8361


Repository: mesos


Description
-------

Unifies handling of 'local' when supplied for the '--master' flag.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
  src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
  src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
  src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
  src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
  src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64857/diff/3/

Changes: https://reviews.apache.org/r/64857/diff/2-3/


Testing
-------

make check


Thanks,

Till Toenshoff

Re: Review Request 64857: Updated example frameworks for mesos-local.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64857/
-----------------------------------------------------------

(Updated Jan. 9, 2018, 3:19 a.m.)


Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil Arya, and Vinod Kone.


Bugs: MESOS-8357 and MESOS-8361
    https://issues.apache.org/jira/browse/MESOS-8357
    https://issues.apache.org/jira/browse/MESOS-8361


Repository: mesos


Description
-------

Unifies handling of 'local' when supplied for the '--master' flag.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp 410966e64aa3f146a88c00babaa51b499dd24d36 
  src/examples/disk_full_framework.cpp d75f769538d17229bdbf332ea7513b1aa8d7c334 
  src/examples/docker_no_executor_framework.cpp 1fa408d3847d414c23eed8334db8de02e84cf764 
  src/examples/dynamic_reservation_framework.cpp 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 
  src/examples/load_generator_framework.cpp 42867992eba8699cab5b70c62a24b87446139406 
  src/examples/long_lived_framework.cpp 943160d5a42e02cf05fe92999233ce2e792849fd 
  src/examples/no_executor_framework.cpp 972ef777cec07d1030af208daef69ebe606d071e 
  src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 
  src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a 


Diff: https://reviews.apache.org/r/64857/diff/2/

Changes: https://reviews.apache.org/r/64857/diff/1-2/


Testing
-------

make check


Thanks,

Till Toenshoff