You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/12/11 04:31:18 UTC

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 3:31 a.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Nate Cole.


Bugs: AMBARI-8449
    https://issues.apache.org/jira/browse/AMBARI-8449


Repository: ambari


Description
-------

The requirement for Upgrade Pack definition is Epic.
Phase 1, HDFS and ZK
Phase 2, Yarn and HBASE

This still has 3 pending items:
1. ResourceManager and Node manager also have HA steps
2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
3. Fix some of the TODOs, like hardcoding the JMX port number


Diffs
-----

  ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 988e272 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java bc5d4a1 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 

Diff: https://reviews.apache.org/r/28855/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:49.356s
[INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
[INFO] Final Memory: 46M/386M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64687
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/28855/#comment107489>

    Definite revisit potential; we'll need this for all HA-able services.  Useful even beyond upgrades too.


- Nate Cole


On Dec. 10, 2014, 10:33 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 10:33 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 988e272 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java bc5d4a1 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64679
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/28855/#comment107481>

    Runbook says JN come before NN, and one-by-one like ZK.



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/28855/#comment107482>

    Runbook says the other way around.



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/28855/#comment107483>

    Should not need the element if there's nothing to do



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/28855/#comment107484>

    No it's not misleading, it's conceivable to have things that can happen after the component, but before the end of the entire cluster.  Remove this comment and element.


- Nate Cole


On Dec. 10, 2014, 10:33 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 10:33 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 988e272 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java bc5d4a1 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64686
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/28855/#comment107488>

    If order is important, then use a LinkedHashSet.  List is dangerous in this case because you can't do something like ["h1", "h2", "h1"].  LinkedHashSet maintains predictable order.  Don't change StageWrapperBuilder's add() contract.


- Nate Cole


On Dec. 10, 2014, 10:33 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 10:33 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 988e272 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java bc5d4a1 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64706
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 10, 2014, 11:59 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64713
-----------------------------------------------------------

Ship it!


Looks good.  Coupke minor questions.


ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/28855/#comment107511>

    Should this be private static?



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/28855/#comment107512>

    Should this be static?


- Tom Beerbower


On Dec. 11, 2014, 4:59 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 4:59 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64783
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 11, 2014, 2:46 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 2:46 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py ef44ca4 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 66df9ff 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 7bd7591 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 15399b5 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py ade2cf5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 619fc3a 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 88b6125 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 7:46 p.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.


Changes
-------

Rebased and addressed Tom's comments.


Bugs: AMBARI-8449
    https://issues.apache.org/jira/browse/AMBARI-8449


Repository: ambari


Description
-------

The requirement for Upgrade Pack definition is Epic.
Phase 1, HDFS and ZK
Phase 2, Yarn and HBASE

This still has 3 pending items:
1. ResourceManager and Node manager also have HA steps
2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
3. Fix some of the TODOs, like hardcoding the JMX port number


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/shell.py ef44ca4 
  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 66df9ff 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 7bd7591 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 15399b5 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py ade2cf5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 619fc3a 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 88b6125 

Diff: https://reviews.apache.org/r/28855/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:49.356s
[INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
[INFO] Final Memory: 46M/386M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64764
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 10, 2014, 11:59 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Alejandro Fernandez <af...@hortonworks.com>.


> On Dec. 11, 2014, 2:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py, line 34
> > <https://reviews.apache.org/r/28855/diff/4/?file=789113#file789113line34>
> >
> >     I might not understand the full scope of rolling updates and automated updates, but it seems like this parameter should be for both rolling restarts and regular old automated upgrade restarts.
> >     
> >     In other words, I should be able to use this boolean whether or not the upgrade is rolling, right?
> >     
> >     In which case, I think this should be "upgrading=False". 
> >     
> >     If I'm wrong, then don't we need another boolean to also track automated upgrades (as opposed to those that are rolling?)

We can cross that bridge once we get there. We haven't identified the differences between a traditional upgrade and a rolling upgrade. If it's alright, I prefer to keep this as rolling_restart for now; in the future we may have upgrade=True, rolling_restart=False as a possible combination.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64730
-----------------------------------------------------------


On Dec. 11, 2014, 4:59 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 4:59 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64730
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py
<https://reviews.apache.org/r/28855/#comment107520>

    I might not understand the full scope of rolling updates and automated updates, but it seems like this parameter should be for both rolling restarts and regular old automated upgrade restarts.
    
    In other words, I should be able to use this boolean whether or not the upgrade is rolling, right?
    
    In which case, I think this should be "upgrading=False". 
    
    If I'm wrong, then don't we need another boolean to also track automated upgrades (as opposed to those that are rolling?)


- Jonathan Hurley


On Dec. 10, 2014, 11:59 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Alejandro Fernandez <af...@hortonworks.com>.


> On Dec. 11, 2014, 3:58 p.m., Nate Cole wrote:
> > We are going to be removing those tasks out of XML right?

Yes, I plan to do that in a future commit.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64736
-----------------------------------------------------------


On Dec. 11, 2014, 4:59 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 4:59 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/#review64736
-----------------------------------------------------------


We are going to be removing those tasks out of XML right?

- Nate Cole


On Dec. 10, 2014, 11:59 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28855/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 11:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8449
>     https://issues.apache.org/jira/browse/AMBARI-8449
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The requirement for Upgrade Pack definition is Epic.
> Phase 1, HDFS and ZK
> Phase 2, Yarn and HBASE
> 
> This still has 3 pending items:
> 1. ResourceManager and Node manager also have HA steps
> 2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
> 3. Fix some of the TODOs, like hardcoding the JMX port number
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
>   ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 
> 
> Diff: https://reviews.apache.org/r/28855/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:49.356s
> [INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
> [INFO] Final Memory: 46M/386M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 4:59 a.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.


Changes
-------

Addressed Nate's comments.


Bugs: AMBARI-8449
    https://issues.apache.org/jira/browse/AMBARI-8449


Repository: ambari


Description
-------

The requirement for Upgrade Pack definition is Epic.
Phase 1, HDFS and ZK
Phase 2, Yarn and HBASE

This still has 3 pending items:
1. ResourceManager and Node manager also have HA steps
2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
3. Fix some of the TODOs, like hardcoding the JMX port number


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 

Diff: https://reviews.apache.org/r/28855/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:49.356s
[INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
[INFO] Final Memory: 46M/386M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez

Re: Review Request 28855: Upgrade Pack definition for Core Master Components

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28855/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 3:33 a.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, and Tom Beerbower.


Bugs: AMBARI-8449
    https://issues.apache.org/jira/browse/AMBARI-8449


Repository: ambari


Description
-------

The requirement for Upgrade Pack definition is Epic.
Phase 1, HDFS and ZK
Phase 2, Yarn and HBASE

This still has 3 pending items:
1. ResourceManager and Node manager also have HA steps
2. When starting a daemon services, the path of the binaries uses from /usr/hdp/current should be from the appropriate "server" symlink folder, since in some cases this is coming from the client folder
3. Fix some of the TODOs, like hardcoding the JMX port number


Diffs
-----

  ambari-common/src/main/python/resource_management/core/shell.py cd8b05b 
  ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py fb5ffb4 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 64af325 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8201a8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 988e272 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java f99ee72 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java bc5d4a1 
  ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 269abdb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 66e40d5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 158f855 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 93947b1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py a26254d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 8d66dcc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 758fa5f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py 3b4cf3e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py c773902 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py c0b2181 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py 68d0bd4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 02e6235 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 5eb25d2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py 3362f91 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py c58446e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py 6ee5507 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 2c48e4c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 885cf06 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/webhcat_server.py 088cb41 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_server.py 70414fc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/application_timeline_server.py 75a4710 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 2485d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py 8e153e0 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 3557d9d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py b87232f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 533e9b3 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py a1a25b8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9643e87 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 0d9aeea 

Diff: https://reviews.apache.org/r/28855/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:49.356s
[INFO] Finished at: Wed Dec 10 17:43:22 PST 2014
[INFO] Final Memory: 46M/386M
[INFO] ------------------------------------------------------------------------


Thanks,

Alejandro Fernandez