You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2014/05/25 15:05:12 UTC
Fwd: svn commit: r1597377 -
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
I do not like having v to use two annotations. What not @PluginAttribute (name="someName", defaultValue=123)?
Gary
<div>-------- Original message --------</div><div>From: mattsicker@apache.org </div><div>Date:05/25/2014 00:05 (GMT-05:00) </div><div>To: commits@logging.apache.org </div><div>Subject: svn commit: r1597377 -
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java </div><div>
</div>Author: mattsicker
Date: Sun May 25 04:05:52 2014
New Revision: 1597377
URL: http://svn.apache.org/r1597377
Log:
Change Boolean to boolean in factory method.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java?rev=1597377&r1=1597376&r2=1597377&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java Sun May 25 04:05:52 2014
@@ -181,7 +181,7 @@ public final class AsyncAppender extends
@PluginFactory
public static AsyncAppender createAppender(@PluginElement("AppenderRef") final AppenderRef[] appenderRefs,
@PluginAttribute("errorRef") @PluginAliases("error-ref") final String errorRef,
- @PluginAttribute("blocking") @PluginDefault("true") final Boolean blocking,
+ @PluginAttribute("blocking") @PluginDefault("true") final boolean blocking,
@PluginAttribute("bufferSize") @PluginDefault(DEFAULT_QUEUE_SIZE) final int size,
@PluginAttribute("name") final String name,
@PluginAttribute("includeLocation") @PluginDefault("false") final boolean includeLocation,
Re: Fwd: svn commit: r1597377 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
Posted by Matt Sicker <bo...@gmail.com>.
I've added defaultValue to @PluginAttribute. However, now that I'm also
going through with creating Builder classes instead of the uber-factory
method, default values may be less necessary as you can specify a default
field value in Java.
On 25 May 2014 17:22, Matt Sicker <bo...@gmail.com> wrote:
> That's a very good idea! I liked not having to specify attribute names in
> annotations so much that I totally missed that idea.
>
>
> On 25 May 2014 08:05, Gary Gregory <ga...@gmail.com> wrote:
>
>> I do not like having v to use two annotations. What not @PluginAttribute
>> (name="someName", defaultValue=123)?
>>
>> Gary
>>
>>
>> -------- Original message --------
>> From: mattsicker@apache.org
>> Date:05/25/2014 00:05 (GMT-05:00)
>> To: commits@logging.apache.org
>> Subject: svn commit: r1597377 -
>> /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>>
>>
>> Author: mattsicker
>> Date: Sun May 25 04:05:52 2014
>> New Revision: 1597377
>>
>> URL: http://svn.apache.org/r1597377
>> Log:
>> Change Boolean to boolean in factory method.
>>
>> Modified:
>>
>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>>
>> Modified:
>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>> URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java?rev=1597377&r1=1597376&r2=1597377&view=diff
>>
>> ==============================================================================
>> ---
>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>> (original)
>> +++
>> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>> Sun May 25 04:05:52 2014
>> @@ -181,7 +181,7 @@ public final class AsyncAppender extends
>> @PluginFactory
>> public static AsyncAppender
>> createAppender(@PluginElement("AppenderRef") final AppenderRef[]
>> appenderRefs,
>> @PluginAttribute("errorRef") @PluginAliases("error-ref")
>> final String errorRef,
>> - @PluginAttribute("blocking") @PluginDefault("true") final
>> Boolean blocking,
>> + @PluginAttribute("blocking") @PluginDefault("true") final
>> boolean blocking,
>> @PluginAttribute("bufferSize")
>> @PluginDefault(DEFAULT_QUEUE_SIZE) final int size,
>> @PluginAttribute("name") final String name,
>> @PluginAttribute("includeLocation") @PluginDefault("false")
>> final boolean includeLocation,
>>
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: Fwd: svn commit: r1597377 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
Posted by Matt Sicker <bo...@gmail.com>.
That's a very good idea! I liked not having to specify attribute names in
annotations so much that I totally missed that idea.
On 25 May 2014 08:05, Gary Gregory <ga...@gmail.com> wrote:
> I do not like having v to use two annotations. What not @PluginAttribute
> (name="someName", defaultValue=123)?
>
> Gary
>
>
> -------- Original message --------
> From: mattsicker@apache.org
> Date:05/25/2014 00:05 (GMT-05:00)
> To: commits@logging.apache.org
> Subject: svn commit: r1597377 -
> /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>
>
> Author: mattsicker
> Date: Sun May 25 04:05:52 2014
> New Revision: 1597377
>
> URL: http://svn.apache.org/r1597377
> Log:
> Change Boolean to boolean in factory method.
>
> Modified:
>
> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java?rev=1597377&r1=1597376&r2=1597377&view=diff
>
> ==============================================================================
> ---
> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
> (original)
> +++
> logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
> Sun May 25 04:05:52 2014
> @@ -181,7 +181,7 @@ public final class AsyncAppender extends
> @PluginFactory
> public static AsyncAppender
> createAppender(@PluginElement("AppenderRef") final AppenderRef[]
> appenderRefs,
> @PluginAttribute("errorRef") @PluginAliases("error-ref")
> final String errorRef,
> - @PluginAttribute("blocking") @PluginDefault("true") final
> Boolean blocking,
> + @PluginAttribute("blocking") @PluginDefault("true") final
> boolean blocking,
> @PluginAttribute("bufferSize")
> @PluginDefault(DEFAULT_QUEUE_SIZE) final int size,
> @PluginAttribute("name") final String name,
> @PluginAttribute("includeLocation") @PluginDefault("false")
> final boolean includeLocation,
>
>
>
--
Matt Sicker <bo...@gmail.com>