[GitHub] [spark] HyukjinKwon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710728304



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
    */
   def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
 
+  /**
+   * SQL ILIKE expression (case insensitive LIKE).
+   *
+   * @group expr_ops
+   * @since 3.3.0
+   */
+  def ilike(literal: String, escapeChar: Char = '\\'): Column = withExpr {

Review comment:
       yeah, let's don't add it for now. these DSL APIs don't usually have all matched APIs but just commonly used ones (that make sense to Scala, Python, etc users instead of SQL users)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org