You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/11/22 18:21:24 UTC

[GitHub] [mynewt-core] andrzej-kaczmarek commented on issue #2108: Hardware stack limiter for CM33

andrzej-kaczmarek commented on issue #2108: Hardware stack limiter for CM33
URL: https://github.com/apache/mynewt-core/pull/2108#issuecomment-557638512
 
 
   @wes @kasjer 
   I also opt for having it always enabled
   and I'm fine with storing stack bottom in `os_task`, not sure if we need stack top, bottom and size stored at the same time but as far as I see there is code in e.g. mcumgr which unfortunately accesses `os_task` struct directly (which I don't like, this should be done via API) so perhaps it's better to just add stack bottom as some things may break if we remove stack top. do you have any strong opinion on this?
   will also add comment to make sure no one moves these members in future

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services