[jira] [Work logged] (AVRO-3616) [C++]: Fix compilation warnings

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3616?focusedWorklogId=802838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802838 ]

ASF GitHub Bot logged work on AVRO-3616:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Aug/22 12:47
            Start Date: 23/Aug/22 12:47
    Worklog Time Spent: 10m 
      Work Description: martin-g opened a new pull request, #1836:
URL: https://github.com/apache/avro/pull/1836

   
   ### Jira
   
   - [X] https://issues.apache.org/jira/browse/AVRO-3616
   
   ### Tests
   
   - [X] My PR updates existing unit tests
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] No need




Issue Time Tracking
-------------------

            Worklog Id:     (was: 802838)
    Remaining Estimate: 0h
            Time Spent: 10m

> [C++]: Fix compilation warnings
> -------------------------------
>
>                 Key: AVRO-3616
>                 URL: https://issues.apache.org/jira/browse/AVRO-3616
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: c++
>    Affects Versions: 1.11.1
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Building the C++ SDK prints two types of warnings:
>  
> 1. Usage of deprecated Boost test related import
> {code:java}
>  In file included from /usr/include/boost/config/header_deprecated.hpp:18,
>     from /usr/include/boost/test/included/unit_test_framework.hpp:12,
>     from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19:
>     
>     /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: #pragma message: This header is deprecated. Use This header is deprecated. Please use <boost/test/included/unit_test.hpp> instead. instead.
>   13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use <boost/test/included/unit_test.hpp> instead." )
>           | ^~~~~~~~~~~~~~~~~~~~~~~{code}
> 2. Wrong order of constructor arguments
> {code:java}
> In file included from /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh: In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after [-Wreorder]  200 |     Codec codec_;      |           ^~~~~~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:   ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 |     const DecoderPtr decoder_;      |                      ^~~~~~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: warning:   when initialized here [-Wreorder]  262 | DataFileReaderBase::DataFileReaderBase(const char *filename) : filename_(filename), stream_(fileSeekableInputStream(filename)), codec_(NULL_CODEC),      | ^~~~~~~~~~~~~~~~~~In file included from /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh: In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr<avro::InputStream>)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after [-Wreorder]  200 |     Codec codec_;      |           ^~~~~~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning:   ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder]  197 |     const DecoderPtr decoder_;      |                      ^~~~~~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: warning:   when initialized here [-Wreorder]  268 | DataFileReaderBase::DataFileReaderBase(std::unique_ptr<InputStream> inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code}
> Full example could be seen at https://github.com/apache/avro/runs/7959849252?check_suite_focus=true



--
This message was sent by Atlassian Jira
(v8.20.10#820010)