[GitHub] [flink] danny0405 edited a comment on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

[GitBox <gi...@apache.org>]

danny0405 edited a comment on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL
URL: https://github.com/apache/flink/pull/8548#issuecomment-498509086
 
 
   @twalthr 
   
   1. I agree that remove the colon between ROW type field name and type is more in line with the sql standard
   2. I agree that use left/right paren is more SQL compliant
   3. I agree to add comments for row type item
   4. The parameterized VARCHARs is supported as a builtin type in Calcite, and our test 
   already extends it.
   5. I don't think we should support type keyword like `STRING` or `BYTES`, same reason for SQL compliant
   6. REAL is supported by CALCTE, it's hard to say we do not support it, exclude the REAL type will bring a lot of extra work
   
   For other data types that are listed in FLIP-37 but not in this PR, i would rather fire a new JIRA issue for tracing them, after all,
   support the types Flink implement in query execution has higher priority than those that are not totally supported.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services